+1 Best,
Xintong On Fri, Jul 21, 2023 at 10:53 AM Wencong Liu <liuwencle...@163.com> wrote: > Hi devs, > > I would like to start a discussion on FLIP-343: Remove parameter in > WindowAssigner#getDefaultTrigger() [1]. > > > The method getDefaultTrigger() in WindowAssigner takes a > StreamExecutionEnvironment > parameter, but this parameter is not actually used for any subclasses of > WindowAssigner. > Therefore, it is unnecessary to include this parameter. > As such I propose to remove the StreamExecutionEnvironment field from > WindowAssigner#getDefaultTrigger(StreamExecutionEnvironment env). > Looking forward to your feedback. > [1] > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229 > Best regards, > > > Wencong Liu
