Hi Martijn,
thanks a lot for taking this

+1 (non-binding)

- checked signatures and checksums
- checked that no binaries
- checked NOTICE and LICENSE
- checked web PR

there is one minor I noticed: the connector still uses "io.github.zentol
.flink" for flink-connector-parent
I submitted a PR[1] to fix that, however it shouldn't be a blocker

[1] https://github.com/apache/flink-connector-hbase/pull/18


On Mon, Sep 4, 2023 at 10:52 AM Ahmed Hamdy <hamdy10...@gmail.com> wrote:

> Hi Martijn,
> +1 (non-binding)
>
> - verified Checksums and signatures
> - no binaries in source
> - Checked NOTICE files contains migrated artifacts
> - tag is correct
> - Approved Web PR
>
> Best Regards
> Ahmed Hamdy
>
>
> On Fri, 1 Sept 2023 at 15:35, Martijn Visser <martijnvis...@apache.org>
> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #2 for the version 3.0.0,
> > as follows:
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to dist.apache.org
> > [2],
> > which are signed with the key with fingerprint
> > A5F3BCE4CBE993573EC5966A65321B8382B219AF [3],
> > * all artifacts to be deployed to the Maven Central Repository [4],
> > * source code tag v3.0.0-rc2 [5],
> > * website pull request listing the new release [6].
> >
> > This replaces the old, cancelled vote of RC1 [7]. This version is the
> > externalized version which is compatible with Flink 1.16 and 1.17.
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PMC affirmative votes.
> >
> > Thanks,
> > Release Manager
> >
> > [1]
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352578
> > [2]
> >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-hbase-3.0.0-rc2
> > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > [4]
> https://repository.apache.org/content/repositories/orgapacheflink-1650
> > [5]
> > https://github.com/apache/flink-connector-hbase/releases/tag/v3.0.0-rc2
> > [6] https://github.com/apache/flink-web/pull/591
> > [7] https://lists.apache.org/thread/wbl6sc86q9s5mmz5slx4z09svh91cpr0
> >
>


-- 
Best regards,
Sergey

Reply via email to