Hey Martijn, thanks for driving this.
-1 (binding) due to the concerns highlighted below
- NOTICE files are present
- Note: The copyright year is out of data (2020)
- Concern: we bundle AnchorJS (MIT) v3.1.0 and this is not listed in the
NOTICE file
- Concern: "statefun-sdk-java" bundles
"com.google.auto.service:auto-service-annotations:jar:1.0-rc6" but does not
declare it in the NOTICE
- Concern: "statefun-flink-distribution"
- bundles "org.apache.kafka:kafka-clients:3.2.3" but declares
"org.apache.kafka:kafka-clients:2.4.1"
- bundles "com.github.luben:zstd-jni:1.5.2-1" but declares
"com.github.luben:zstd-jni:1.4.3-1"
- bundles "com.fasterxml.jackson.core:jackson-core:2.13.4" but declares
"com.fasterxml.jackson.core:jackson-core:2.12.1"
- bundles "com.fasterxml.jackson.core:jackson-annotations:2.13.4" but
declares "com.fasterxml.jackson.core:jackson-annotations:2.12.1"
- bundles "com.fasterxml.jackson.core:jackson-databind:2.13.4.2" but
declares "com.fasterxml.jackson.core:jackson-databind:2.12.1"
- bundles
"com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.13.4" but
declares "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:2.12.1"
- bundles "commons-io:commons-io:jar:2.11.0" but declares
"commons-io:commons-io:jar:2.8.0"
- bundles "commons-codec:commons-codec:1.15" but declares
"commons-codec:commons-codec:1.13"
- bundles "com.esotericsoftware.minlog:minlog:1.2" but does not declare
it
- bundles "com.ibm.icu:icu4j:jar:67.1" but does not declare it
- bundles "org.objenesis:objenesis:jar:2.1" but does not declare it
- bundles "com.esotericsoftware.kryo:kryo:2.24.0" but does not declare
it
- bundles "commons-collections:commons-collections:3.2.2" but does not
declare it
- bundles "org.apache.commons:commons-compress:1.21" but does not
declare it
- Verified nexus repo contents are similar to 3.2.0
- Sigs and checksums of dist look good
- Verified there are no binaries in the source archive
- Maven build+tests complete successfully
- Reviewed the Docker PR
- Reviewed website PR
- Release notes look good
- Tag is present in Github
- LICENSE file is present
- Source files include Apache copyright header
- Note: Github workflow configuration files do not, however there is an
explicit exclude in the pom, so assuming this is intentional
Thanks,
Danny
On Fri, Sep 8, 2023 at 12:53 PM Martijn Visser <martijnvis...@apache.org>
wrote:
> Hi everyone,
>
> Please review [1] and vote on the release candidate #1 for the version
> 3.3.0 of Apache Flink Stateful Functions,
> as follows:
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> **Release Overview**
>
> As an overview, the release consists of the following:
> a) Stateful Functions canonical source distribution, to be deployed to the
> release repository at dist.apache.org
> b) Stateful Functions Python SDK distributions to be deployed to PyPI
> c) Maven artifacts to be deployed to the Maven Central Repository
> d) Dockerfiles for new images to be deployed to Docker Hub
>
> **Staging Areas to Review**
>
> The staging areas containing the above mentioned artifacts are as follows,
> for your review:
> * All artifacts for a) and b) can be found in the corresponding dev
> repository at dist.apache.org [2]
> * All artifacts for c) can be found at the Apache Nexus Repository [3]
> * PR for new Dockerfiles for this release [4]
>
> All artifacts are signed with the key with fingerprint
> A5F3BCE4CBE993573EC5966A65321B8382B219AF [5]
>
> Other links for your review:
> * JIRA release notes [6]
> * source code tag "release-3.3.0-rc1" [7]
> * PR to update the website Downloads page to include Stateful Functions
> links [8]
>
> **Vote Duration**
>
> The voting time will run for at least 72 hours.
> It is adopted by majority approval, with at least 3 PMC affirmative votes.
>
> Thanks,
> Release manager
>
> [1]
>
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Stateful+Functions+Release
> [2] https://dist.apache.org/repos/dist/dev/flink/flink-statefun-3.3.0-rc1/
> [3]
> https://repository.apache.org/content/repositories/orgapacheflink-1652/
> [4] https://github.com/apache/flink-statefun-docker/pull/20
> [5] https://dist.apache.org/repos/dist/release/flink/KEYS
> [6]
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12351276
> [7] https://github.com/apache/flink-statefun/tree/release-3.3.0-rc1
> [8] https://github.com/apache/flink-web/pull/674
>
