+1 good idea! Looking forward to Flink OLAP! Best regards, Jing
On Sat, Oct 7, 2023 at 1:36 PM Yangze Guo <[email protected]> wrote: > Thanks for all your comments. > > @Rui > Thanks for the reminder. The "env.java.opts.all" has already taken effect > now. > > > Best, > Yangze Guo > > On Sat, Oct 7, 2023 at 6:45 PM Benchao Li <[email protected]> wrote: > > > > Thanks Yangze for preparing this FLIP, it's good to have this ability > > for gateway since we already have it for other JVM processes > > (client/JM/TM) as Rui mentioned. > > > > Rui Fan <[email protected]> 于2023年10月7日周六 18:02写道： > > > > > > Thanks to Yangze driving this proposal. > > > > > > `env.java.opts.xxx` is already supported for client, historyserver, > > > jobmanager and taskmanager. And it's very useful for troubleshooting. > > > So +1 for `env.java.opts.sql-gateway`. > > > > > > I have a minor question: doesn't the `env.java.opts.all` support > > > sql-gateway? > > > If yes, it's fine. If no, it's better to consider it to be the subtask > of > > > this FLIP. > > > > > > Best, > > > Rui > > > > > > > > > On Sat, Oct 7, 2023 at 4:35 PM xiangyu feng <[email protected]> > wrote: > > > > > > > Thanks for initiating this discussion. Within the development towards > > > > Streaming Warehousing, SQL Gateway will become more and more > important. > > > > Big +1 to specify Java Options separately for SQL Gateway. > > > > > > > > Regards, > > > > Xiangyu > > > > > > > > Yangze Guo <[email protected]> 于2023年10月7日周六 15:24写道： > > > > > > > > > Hi, there, > > > > > > > > > > We'd like to start a discussion thread on "FLIP-374: Adding a > separate > > > > > configuration for specifying Java Options of the SQL Gateway"[1], > > > > > where we propose adding a separate configuration option to specify > the > > > > > Java options for the SQL Gateway. This would allow users to > fine-tune > > > > > the memory settings, garbage collection behavior, and other > relevant > > > > > Java parameters specific to the SQL Gateway, ensuring optimal > > > > > performance and stability in production environments. > > > > > > > > > > Looking forward to your feedback. > > > > > > > > > > [1] > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-374%3A+Adding+a+separate+configuration+for+specifying+Java+Options+of+the+SQL+Gateway > > > > > > > > > > Best, > > > > > Yangze Guo > > > > > > > > > > > > > > > > > -- > > > > Best, > > Benchao Li >
