+1 (non-binding) - Verified Singatures - Verified Checksum - Build source successfully - Checked release tag exists - Reviewed the web PR Best Regards Ahmed Hamdy
On Sun, 29 Oct 2023 at 08:02, Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - Verified signatures > - Verified hashsums > - Checked Github release tag > - Built from source code succeeded > - Checked release notes > - Reviewed the web PR > > Best, > Leonard > > > > 2023年10月29日 上午11:34，mystic lama <mysticlama...@gmail.com> 写道： > > > > +1 (non-binding) > > > > - verified signatures > > - build with Java 8 and Java 11 - build success > > > > Minor observation > > - RAT check flagged that README.md is missing ASL > > > > On Fri, 27 Oct 2023 at 23:40, Xianxun Ye <yesorno828...@gmail.com> > wrote: > > > >> +1(non-binding) > >> > >> - Started a local Flink 1.18 cluster, read and wrote with Kafka and > Upsert > >> Kafka connector successfully to Kafka 2.2 cluster > >> > >> One minor question: should we update the dependency manual of these two > >> documentations[1][2]? > >> > >> [1] > >> > https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/kafka/#dependencies > >> [2] > >> > https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/table/upsert-kafka/#dependencies > >> > >> Best regards, > >> Xianxun > >> > >>> 2023年10月26日 16:12，Martijn Visser <martijnvis...@apache.org> 写道： > >>> > >>> +1 (binding) > >>> > >>> - Validated hashes > >>> - Verified signature > >>> - Verified that no binaries exist in the source archive > >>> - Build the source with Maven via mvn clean install > >>> -Pcheck-convergence -Dflink.version=1.18.0 > >>> - Verified licenses > >>> - Verified web PR > >>> - Started a cluster and the Flink SQL client, successfully read and > >>> wrote with the Kafka connector to Confluent Cloud with AVRO and Schema > >>> Registry enabled > >>> > >>> On Thu, Oct 26, 2023 at 5:09 AM Qingsheng Ren <re...@apache.org> > wrote: > >>>> > >>>> +1 (binding) > >>>> > >>>> - Verified signature and checksum > >>>> - Verified that no binary exists in the source archive > >>>> - Built from source with Java 8 using -Dflink.version=1.18 > >>>> - Started a local Flink 1.18 cluster, submitted jobs with SQL client > >>>> reading from and writing (with exactly-once) to Kafka 3.2.3 cluster > >>>> - Nothing suspicious in LICENSE and NOTICE file > >>>> - Reviewed web PR > >>>> > >>>> Thanks for the effort, Gordon! > >>>> > >>>> Best, > >>>> Qingsheng > >>>> > >>>> On Thu, Oct 26, 2023 at 5:13 AM Tzu-Li (Gordon) Tai < > >> tzuli...@apache.org> > >>>> wrote: > >>>> > >>>>> Hi everyone, > >>>>> > >>>>> Please review and vote on release candidate #1 for version 3.0.1 of > the > >>>>> Apache Flink Kafka Connector, as follows: > >>>>> [ ] +1, Approve the release > >>>>> [ ] -1, Do not approve the release (please provide specific comments) > >>>>> > >>>>> This release contains important changes for the following: > >>>>> - Supports Flink 1.18.x series > >>>>> - [FLINK-28303] EOS violation when using LATEST_OFFSETS startup mode > >>>>> - [FLINK-33231] Memory leak causing OOM when there are no offsets to > >> commit > >>>>> back to Kafka > >>>>> - [FLINK-28758] FlinkKafkaConsumer fails to stop with savepoint > >>>>> > >>>>> The release candidate contains the source release as well as JAR > >> artifacts > >>>>> to be released to Maven, built against Flink 1.17.1 and 1.18.0. > >>>>> > >>>>> The complete staging area is available for your review, which > includes: > >>>>> * JIRA release notes [1], > >>>>> * the official Apache source release to be deployed to > dist.apache.org > >>>>> [2], > >>>>> which are signed with the key with fingerprint > >>>>> 1C1E2394D3194E1944613488F320986D35C33D6A [3], > >>>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>>> * source code tag v3.0.1-rc1 [5], > >>>>> * website pull request listing the new release [6]. > >>>>> > >>>>> The vote will be open for at least 72 hours. It is adopted by > majority > >>>>> approval, with at least 3 PMC affirmative votes. > >>>>> > >>>>> Thanks, > >>>>> Gordon > >>>>> > >>>>> [1] > >>>>> > >>>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12352910 > >>>>> [2] > >>>>> > >>>>> > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-kafka-3.0.1-rc1/ > >>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>> [4] > >> https://repository.apache.org/content/repositories/orgapacheflink-1664 > >>>>> [5] > https://github.com/apache/flink-connector-kafka/commits/v3.0.1-rc1 > >>>>> [6] https://github.com/apache/flink-web/pull/692 > >>>>> > >> > >> > >
