Hi Junrui, Thanks for bringing the proposal to our attention. It looks overall great.
I am just a little bit confused with the content of Flip with the following questions: 1. How many complex java classes will be deprecated? 2. After reading the section title "Deprecate following classes, fields and methods", I thought that e.g. org.apache.flink.streaming.api.environment.StreamExecutionEnvironment will be deprecated. I would suggest restructure the content and point out clearly which entire classes will be deprecated and which methods and fields and not the class itself will be deprecated instead of mixing them up. WDYT? Best regards, Jing On Fri, Nov 3, 2023 at 8:59 AM Wencong Liu <liuwencle...@163.com> wrote: > Thanks Junrui for your effort! > > Making all configuration code paths lead to ConfigOption is a more > standardized > approach to configuring Flink applications. > > +1 for this proposal. > > Best, > Wencong Liu > > > > > > > > > > > > > > > At 2023-11-02 10:10:14, "Junrui Lee" <jrlee....@gmail.com> wrote: > >Hi devs, > > > >I would like to start a discussion on FLIP-381: Deprecate configuration > >getters/setters that return/set complex Java objects[1]. > > > >Currently, the job configuration in FLINK is spread out across different > >components, which leads to inconsistencies and confusion. To address this > >issue, it is necessary to migrate non-ConfigOption complex Java objects to > >use ConfigOption and adopt a single Configuration object to host all the > >configuration. > >However, there is a significant blocker in implementing this solution. > >These complex Java objects in StreamExecutionEnvironment, > CheckpointConfig, > >and ExecutionConfig have already been exposed through the public API, > >making it challenging to modify the existing implementation. > > > >Therefore, I propose to deprecate these Java objects and their > >corresponding getter/setter interfaces, ultimately removing them in > >FLINK-2.0. > > > >Your feedback and thoughts on this proposal are highly appreciated. > > > >Best regards, > >Junrui Lee > > > >[1] > > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=278464992 >
