+1 (non-binding)

- Verified signatures
- Build the source with Maven
- start cluster bin/start-cluster.sh with java8, it works fine
- started SQL Client, used datagen source to verify several SQL
cases(FLINK-33010,FLINK-32456,FLINK-30966), result seems ok.

Best,
Lincoln Lee


Martijn Visser <martijnvis...@apache.org> 于2023年11月24日周五 17:35写道:

> +1 (binding)
>
> - Validated hashes
> - Verified signature
> - Verified that no binaries exist in the source archive
> - Build the source with Maven
> - Verified licenses
> - Verified web PRs
>
> On Fri, Nov 24, 2023 at 7:25 AM Jing Ge <j...@ververica.com.invalid>
> wrote:
> >
> > +1(not-binding)
> >
> > - verified signatures and hash
> > - reviewed the web PR
> > - checked the tag
> > - verified there are no binaries in the source archive
> > - built from sources
> >
> > Best regards,
> > Jing
> >
> > On Fri, Nov 24, 2023 at 4:07 AM weijie guo <guoweijieres...@gmail.com>
> > wrote:
> >
> > > Sorry, it's a non-binding vote. :)
> > >
> > > Best regards,
> > >
> > > Weijie
> > >
> > >
> > > weijie guo <guoweijieres...@gmail.com> 于2023年11月24日周五 11:05写道:
> > >
> > > > +1 (binding)
> > > >
> > > > - Verified signatures and hashsums
> > > > - Verified POM/NOTICE filess
> > > > - Built from sources.
> > > > - Reviewed the web PR.
> > > >
> > > > Best regards,
> > > >
> > > > Weijie
> > > >
> > > >
> > > > Yuxin Tan <tanyuxinw...@gmail.com> 于2023年11月24日周五 10:18写道:
> > > >
> > > >> +1 (non-binding)
> > > >>
> > > >> - Verified signatures and hashsums
> > > >> - Verified there are no binaries in the source archive
> > > >> - Built Flink from sources
> > > >> - Reviewed the web PR
> > > >>
> > > >> Best,
> > > >> Yuxin
> > > >>
> > > >>
> > > >> Feng Jin <jinfeng1...@gmail.com> 于2023年11月24日周五 02:20写道:
> > > >>
> > > >> > +1(non-binding)
> > > >> >
> > > >> > - verified signatures and hashsums
> > > >> > - Verified there are no binaries in the source archive
> > > >> > - Built Flink from sources
> > > >> > - Started local standalone cluster, submitted sql job using
> sql-client
> > > >> >
> > > >> > Best,
> > > >> > Feng
> > > >> >
> > > >> >
> > > >> > On Thu, Nov 23, 2023 at 11:08 PM Hang Ruan <
> ruanhang1...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> > > +1 (non-binding)
> > > >> > >
> > > >> > > - verified signatures
> > > >> > > - verified hashsums
> > > >> > > - Verified there are no binaries in the source archive
> > > >> > > - reviewed the web PR
> > > >> > > - built Flink from sources
> > > >> > >
> > > >> > > Best,
> > > >> > > Hang
> > > >> > >
> > > >> > > Jiabao Sun <jiabao....@xtransfer.cn.invalid> 于2023年11月23日周四
> > > 22:09写道:
> > > >> > >
> > > >> > > > Thanks for driving this release.
> > > >> > > >
> > > >> > > > +1(non-binding)
> > > >> > > >
> > > >> > > > - Checked the tag in git
> > > >> > > > - Verified signatures and hashsums
> > > >> > > > - Verified there are no binaries in the source archive
> > > >> > > > - Built Flink from sources
> > > >> > > >
> > > >> > > > Best,
> > > >> > > > Jiabao
> > > >> > > >
> > > >> > > >
> > > >> > > > > 2023年11月21日 20:46,Matthias Pohl <matthias.p...@aiven.io
> > > .INVALID>
> > > >> 写道:
> > > >> > > > >
> > > >> > > > > +1 (binding)
> > > >> > > > >
> > > >> > > > > * Downloaded artifacts
> > > >> > > > > * Built Flink from sources
> > > >> > > > > * Verified SHA512 checksums & GPG signatures
> > > >> > > > > * Compared checkout with provided sources
> > > >> > > > > * Verified pom file versions
> > > >> > > > > * Went over NOTICE/pom file changes without finding anything
> > > >> > suspicious
> > > >> > > > > * Deployed standalone session cluster and ran WordCount
> example
> > > in
> > > >> > > batch
> > > >> > > > > and streaming: Nothing suspicious in log files found
> > > >> > > > > * Verified Java version of uploaded binaries
> > > >> > > > >
> > > >> > > > > Thanks Yun Tang for taking care of it.
> > > >> > > > >
> > > >> > > > > On Thu, Nov 16, 2023 at 7:02 AM Rui Fan <
> 1996fan...@gmail.com>
> > > >> > wrote:
> > > >> > > > >
> > > >> > > > >> +1 (non-binding)
> > > >> > > > >>
> > > >> > > > >> - Verified signatures
> > > >> > > > >> - Reviewed the flink-web PR, left a couple of comments
> > > >> > > > >> - The source archives do not contain any binaries
> > > >> > > > >> - Build the source with Maven 3 and java8 (Checked the
> license
> > > as
> > > >> > > well)
> > > >> > > > >> - bin/start-cluster.sh with java8, it works fine and no any
> > > >> > unexpected
> > > >> > > > LOG
> > > >> > > > >> - Ran demo, it's fine:  bin/flink run
> > > >> > > > >> examples/streaming/StateMachineExample.jar
> > > >> > > > >>
> > > >> > > > >> Best,
> > > >> > > > >> Rui
> > > >> > > > >>
> > > >> > > > >> On Mon, Nov 13, 2023 at 4:04 PM Yun Tang <myas...@live.com
> >
> > > >> wrote:
> > > >> > > > >>
> > > >> > > > >>> Hi everyone,
> > > >> > > > >>>
> > > >> > > > >>> Please review and vote on the release candidate #1 for the
> > > >> version
> > > >> > > > >> 1.17.2,
> > > >> > > > >>>
> > > >> > > > >>> as follows:
> > > >> > > > >>>
> > > >> > > > >>> [ ] +1, Approve the release
> > > >> > > > >>>
> > > >> > > > >>> [ ] -1, Do not approve the release (please provide
> specific
> > > >> > comments)
> > > >> > > > >>>
> > > >> > > > >>>
> > > >> > > > >>> The complete staging area is available for your review,
> which
> > > >> > > includes:
> > > >> > > > >>> * JIRA release notes [1],
> > > >> > > > >>>
> > > >> > > > >>> * the official Apache source release and binary
> convenience
> > > >> > releases
> > > >> > > to
> > > >> > > > >> be
> > > >> > > > >>> deployed to dist.apache.org [2], which are signed with
> the
> > > key
> > > >> > with
> > > >> > > > >>> fingerprint 2E0E1AB5D39D55E608071FB9F795C02A4D2482B3 [3],
> > > >> > > > >>>
> > > >> > > > >>> * all artifacts to be deployed to the Maven Central
> Repository
> > > >> [4],
> > > >> > > > >>>
> > > >> > > > >>> * source code tag "release-1.17.2-rc1" [5],
> > > >> > > > >>>
> > > >> > > > >>> * website pull request listing the new release and adding
> > > >> > > announcement
> > > >> > > > >>> blog post [6].
> > > >> > > > >>>
> > > >> > > > >>>
> > > >> > > > >>> The vote will be open for at least 72 hours. It is
> adopted by
> > > >> > > majority
> > > >> > > > >>> approval, with at least 3 PMC affirmative votes.
> > > >> > > > >>>
> > > >> > > > >>>
> > > >> > > > >>> [1]
> > > >> > > > >>>
> > > >> > > > >>
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353260
> > > >> > > > >>>
> > > >> > > > >>> [2]
> > > >> https://dist.apache.org/repos/dist/dev/flink/flink-1.17.2-rc1/
> > > >> > > > >>>
> > > >> > > > >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > >> > > > >>>
> > > >> > > > >>> [4]
> > > >> > > > >>>
> > > >> > > >
> > > >> >
> > >
> https://repository.apache.org/content/repositories/orgapacheflink-1669/
> > > >> > > > >>>
> > > >> > > > >>> [5]
> > > >> > https://github.com/apache/flink/releases/tag/release-1.17.2-rc1
> > > >> > > > >>>
> > > >> > > > >>> [6] https://github.com/apache/flink-web/pull/696
> > > >> > > > >>>
> > > >> > > > >>> Thanks,
> > > >> > > > >>> Release Manager
> > > >> > > > >>>
> > > >> > > > >>
> > > >> > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
>

Reply via email to