Thanks Lincoln for the quick response!
And closing this vote thread, results will be announced in a
separate email. Many thanks to everyone for helping check!
Best,
Rui
On Mon, Nov 27, 2023 at 3:41 PM Lincoln Lee <lincoln.8...@gmail.com> wrote:
> Hi Rui,
>
> Thanks for your quick response and sorry for the false alarm, all the three
> failures are caused by the testing environment(a high version of cluster
> was left in the test environment and interfered with the test, after I
> reset the env, all tests looked good).
>
> So retract my previous -1 vote, and it should be a *+1(non-binding)*
>
> - Verified signatures
> - Build the source with Maven
> - start cluster bin/start-cluster.sh with java8, it works fine
> - started SQL Client, used datagen source to verify several SQL
> cases(FLINK-33010,FLINK-30966,FLINK-31967), result seems ok.
>
>
> Flink SQL> SET execution.runtime-mode = batch;
> [INFO] Session property has been set.
>
> Flink SQL> SET 'sql-client.execution.result-mode' = 'tableau';
> [INFO] Session property has been set.
>
> Flink SQL> CREATE TABLE t1(k STRING, k1 int not null, v BIGINT) WITH
> ('connector'='datagen', 'number-of-rows'='2');
> [INFO] Execute statement succeed.
>
> Flink SQL> SELECT GREATEST(IFNULL(1, 2), IFNULL(2, 1)) from t1;
> +--------+
> | EXPR$0 |
> +--------+
> | 2 |
> | 2 |
> +--------+
> 2 rows in set
>
> Flink SQL> select LAG(k1, 1, cast(null as int)) OVER w from t1 WINDOW w AS
> (ORDER BY proctime());;
> +------------+
> | EXPR$0 |
> +------------+
> | <NULL> |
> | 2120923584 |
> +------------+
> 2 rows in set
>
> Flink SQL> SELECT IF(k1 > 3, 'true', 'false'), k from t1;
> +--------+--------------------------------+
> | EXPR$0 | k |
> +--------+--------------------------------+
> | false | 7facac057b5bcb0966285ffe132... |
> | false | ce142d9f2e2543f386ab880c4ae... |
> +--------+--------------------------------+
> 2 rows in set
>
> Best,
> Lincoln Lee
>
>
> Rui Fan <1996fan...@gmail.com> 于2023年11月27日周一 15:14写道：
>
> > Hey Lincoln,
> >
> > Thanks for your testing and feedback, and I tried it locally with jdk8.
> >
> > 1. start standalone cluster (bin/start-cluster.sh)
> > 2. Run all your sql, everything works fine except the last SQL.
> >
> > Last sql: SELECT IF(k > 3, 'true', 'false'), k from t1;
> > It reports exception:
> >
> > [ERROR] Could not execute SQL statement. Reason:
> > java.lang.NumberFormatException: For input string:
> >
> >
> '4a38ac722d94ccf54297236762dd3a58f98b7972a3c31f7bd20503797b2d26970d28fcd7234737c727c5800c216b51250067'.
> > Invalid character found.
> >
> > Because the k is string instead of int, I update the k to k1, it works
> > fine.
> > SELECT IF(k1 > 3, 'true', 'false'), k1 from t1;
> >
> >
> > Could you provide more exceptions or log about the
> > NullPointerException? Thanks a lot.
> >
> > Best,
> > Rui
> >
> > On Mon, Nov 27, 2023 at 2:47 PM Lincoln Lee <lincoln.8...@gmail.com>
> > wrote:
> >
> > > -1 (not-binding)
> > >
> > > Started SQL Client, used datagen source to verify the fixed SQL issues,
> > but
> > > FLINK-33010, FLINK-30966, FLINK-31967 still got NPE, not sure how much
> > > extra work it would take to fix them at this point, also calcite in
> 1.16
> > is
> > > 3 versions lower than 1.17, so I suggest revert and remove these three
> > > issues from this release.
> > >
> > > test detail:
> > > Flink SQL> SET execution.runtime-mode = batch;
> > > [INFO] Session property has been set.
> > >
> > > Flink SQL> CREATE TABLE t1(k STRING, k1 int not null, v BIGINT) WITH
> > > ('connector'='datagen', 'number-of-rows'='2');
> > > [INFO] Execute statement succeed.
> > >
> > > Flink SQL> SELECT GREATEST(IFNULL(1, 2), IFNULL(2, 1)) from t1;
> > > [ERROR] Could not execute SQL statement. Reason:
> > > java.util.concurrent.CompletionException:
> java.lang.NullPointerException
> > >
> > > Flink SQL> select LAG(k1, 1, cast(null as int)) OVER w from t1 WINDOW w
> > AS
> > > (ORDER BY proctime());
> > > [ERROR] Could not execute SQL statement. Reason:
> > > java.util.concurrent.CompletionException:
> java.lang.NullPointerException
> > >
> > > Flink SQL> SELECT IF(k > 3, 'true', 'false'), k from t1;
> > > [ERROR] Could not execute SQL statement. Reason:
> > > java.util.concurrent.CompletionException:
> java.lang.NullPointerException
> > >
> > > Best,
> > > Lincoln Lee
> > >
> > >
> > > Martijn Visser <martijnvis...@apache.org> 于2023年11月24日周五 16:34写道：
> > >
> > > > +1 (binding)
> > > >
> > > > - Validated hashes
> > > > - Verified signature
> > > > - Verified that no binaries exist in the source archive
> > > > - Build the source with Maven
> > > > - Verified licenses
> > > > - Verified web PRs
> > > >
> > > > On Fri, Nov 24, 2023 at 7:29 AM Jing Ge <j...@ververica.com.invalid>
> > > > wrote:
> > > > >
> > > > > +1(not-binding)
> > > > >
> > > > > - verified signatures hash
> > > > > - verified hash
> > > > > - checked the tag
> > > > > - checked the repo
> > > > > - verified there are no binaries in the source archive
> > > > > - built from sources
> > > > >
> > > > > Best regards,
> > > > > Jing
> > > > >
> > > > > On Thu, Nov 23, 2023 at 7:44 PM Feng Jin <jinfeng1...@gmail.com>
> > > wrote:
> > > > >
> > > > > > +1(non-binding)
> > > > > >
> > > > > > - verified signatures and hashsums
> > > > > > - Verified there are no binaries in the source archive
> > > > > > - Built Flink from sources
> > > > > > - Started local standalone cluster, submitted sql job using
> > > sql-client
> > > > > >
> > > > > > Best,
> > > > > > Feng
> > > > > >
> > > > > > On Thu, Nov 23, 2023 at 11:00 PM Hang Ruan <
> ruanhang1...@gmail.com
> > >
> > > > wrote:
> > > > > >
> > > > > > > +1 (non-binding)
> > > > > > >
> > > > > > > - verified signatures
> > > > > > > - verified hashsums
> > > > > > > - Verified there are no binaries in the source archive
> > > > > > > - reviewed the Release Note
> > > > > > > - reviewed the web PR
> > > > > > >
> > > > > > > Best,
> > > > > > > Hang
> > > > > > >
> > > > > > > Jiabao Sun <jiabao....@xtransfer.cn.invalid> 于2023年11月23日周四
> > > 22:15写道：
> > > > > > >
> > > > > > > > Thanks for driving this release.
> > > > > > > >
> > > > > > > > +1 (non-binding)
> > > > > > > >
> > > > > > > > - Checked the tag in git
> > > > > > > > - Verified signatures and hashsums
> > > > > > > > - Verified there are no binaries in the source archive
> > > > > > > > - Built Flink from sources
> > > > > > > >
> > > > > > > > Best,
> > > > > > > > Jiabao
> > > > > > > >
> > > > > > > > > 2023年11月23日 21:55，Sergey Nuyanzin <snuyan...@gmail.com>
> 写道：
> > > > > > > > >
> > > > > > > > > +1 (non-binding)
> > > > > > > > >
> > > > > > > > > - Downloaded artifacts
> > > > > > > > > - Built Flink from sources
> > > > > > > > > - Verified checksums & signatures
> > > > > > > > > - Verified pom/NOTICE files
> > > > > > > > > - reviewed the web PR
> > > > > > > > >
> > > > > > > > > On Thu, Nov 23, 2023 at 1:28 PM Leonard Xu <
> > xbjt...@gmail.com>
> > > > > > wrote:
> > > > > > > > >
> > > > > > > > >> +1 (binding)
> > > > > > > > >>
> > > > > > > > >> - verified signatures
> > > > > > > > >> - verified hashsums
> > > > > > > > >> - checked that all POM files point to the same version
> > 1.16.3
> > > > > > > > >> - started SQL Client, used MySQL CDC connector to read
> > > changelog
> > > > > > from
> > > > > > > > >> database , the result is expected
> > > > > > > > >> - reviewed the web PR, left minor comment
> > > > > > > > >>
> > > > > > > > >> Best,
> > > > > > > > >> Leonard
> > > > > > > > >>
> > > > > > > > >>> 2023年11月21日 下午8:56，Matthias Pohl <matthias.p...@aiven.io
> > > > .INVALID>
> > > > > > > 写道：
> > > > > > > > >>>
> > > > > > > > >>> +1 (binding)
> > > > > > > > >>>
> > > > > > > > >>> * Downloaded artifacts
> > > > > > > > >>> * Built Flink from sources
> > > > > > > > >>> * Verified SHA512 checksums & GPG signatures
> > > > > > > > >>> * Compared checkout with provided sources
> > > > > > > > >>> * Verified pom file versions
> > > > > > > > >>> * Went over NOTICE/pom file changes without finding
> > anything
> > > > > > > suspicious
> > > > > > > > >>> * Deployed standalone session cluster and ran WordCount
> > > > example in
> > > > > > > > batch
> > > > > > > > >>> and streaming: Nothing suspicious in log files found
> > > > > > > > >>> * Verified Java version of uploaded binaries
> > > > > > > > >>>
> > > > > > > > >>> Thanks for wrapping 1.16 up. :)
> > > > > > > > >>>
> > > > > > > > >>> On Tue, Nov 21, 2023 at 4:55 AM Rui Fan <
> > > 1996fan...@gmail.com>
> > > > > > > wrote:
> > > > > > > > >>>
> > > > > > > > >>>> +1 (non-binding)
> > > > > > > > >>>>
> > > > > > > > >>>> Verified based on this wiki[1].
> > > > > > > > >>>>
> > > > > > > > >>>> - Verified signatures and sha512
> > > > > > > > >>>> - The source archives do not contain any binaries
> > > > > > > > >>>> - Build the source with Maven 3 and java8 (Checked the
> > > > license as
> > > > > > > > well)
> > > > > > > > >>>> - bin/start-cluster.sh with java8, it works fine and no
> > any
> > > > > > > unexpected
> > > > > > > > >> LOG
> > > > > > > > >>>> - Ran demo, it's fine: bin/flink run
> > > > > > > > >>>> examples/streaming/StateMachineExample.jar
> > > > > > > > >>>>
> > > > > > > > >>>> [1]
> > > > > > > > >>>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Release
> > > > > > > > >>>>
> > > > > > > > >>>> Best,
> > > > > > > > >>>> Rui
> > > > > > > > >>>>
> > > > > > > > >>>> On Fri, Nov 17, 2023 at 11:52 AM Yun Tang <
> > myas...@live.com
> > > >
> > > > > > wrote:
> > > > > > > > >>>>
> > > > > > > > >>>>> +1 (non-binding)
> > > > > > > > >>>>>
> > > > > > > > >>>>>
> > > > > > > > >>>>> * Verified signatures
> > > > > > > > >>>>> * Build from source code, and it looks good
> > > > > > > > >>>>> * Verified that jar packages are built with
> maven-3.2.5
> > > and
> > > > > > JDK8
> > > > > > > > >>>>> * Reviewed the flink-web PR
> > > > > > > > >>>>> * Start a local standalone cluster and submit
> examples
> > > > > > > > >>>>>
> > > > > > > > >>>>> Best
> > > > > > > > >>>>> Yun Tang
> > > > > > > > >>>>> ________________________________
> > > > > > > > >>>>> From: Rui Fan <1996fan...@gmail.com>
> > > > > > > > >>>>> Sent: Monday, November 13, 2023 18:20
> > > > > > > > >>>>> To: dev <dev@flink.apache.org>
> > > > > > > > >>>>> Subject: [VOTE] Release 1.16.3, release candidate #1
> > > > > > > > >>>>>
> > > > > > > > >>>>> Hi everyone,
> > > > > > > > >>>>>
> > > > > > > > >>>>> Please review and vote on the release candidate #1 for
> > the
> > > > > > version
> > > > > > > > >>>> 1.16.3,
> > > > > > > > >>>>>
> > > > > > > > >>>>> as follows:
> > > > > > > > >>>>>
> > > > > > > > >>>>> [ ] +1, Approve the release
> > > > > > > > >>>>>
> > > > > > > > >>>>> [ ] -1, Do not approve the release (please provide
> > specific
> > > > > > > comments)
> > > > > > > > >>>>>
> > > > > > > > >>>>>
> > > > > > > > >>>>> The complete staging area is available for your review,
> > > which
> > > > > > > > includes:
> > > > > > > > >>>>> * JIRA release notes [1],
> > > > > > > > >>>>>
> > > > > > > > >>>>> * the official Apache source release and binary
> > convenience
> > > > > > > releases
> > > > > > > > to
> > > > > > > > >>>> be
> > > > > > > > >>>>> deployed to dist.apache.org [2], which are signed with
> > the
> > > > key
> > > > > > > with
> > > > > > > > >>>>> fingerprint B2D64016B940A7E0B9B72E0D7D0528B28037D8BC
> [3],
> > > > > > > > >>>>>
> > > > > > > > >>>>> * all artifacts to be deployed to the Maven Central
> > > > Repository
> > > > > > [4],
> > > > > > > > >>>>>
> > > > > > > > >>>>> * source code tag "release-1.16.3-rc1" [5],
> > > > > > > > >>>>>
> > > > > > > > >>>>> * website pull request listing the new release and
> adding
> > > > > > > > announcement
> > > > > > > > >>>> blog
> > > > > > > > >>>>> post [6].
> > > > > > > > >>>>>
> > > > > > > > >>>>>
> > > > > > > > >>>>> The vote will be open for at least 72 hours. It is
> > adopted
> > > by
> > > > > > > > majority
> > > > > > > > >>>>> approval, with at least 3 PMC affirmative votes.
> > > > > > > > >>>>>
> > > > > > > > >>>>>
> > > > > > > > >>>>> [1]
> > > > > > > > >>>>>
> > > > > > > > >>>>>
> > > > > > > > >>>>
> > > > > > > > >>
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353259
> > > > > > > > >>>>>
> > > > > > > > >>>>> [2]
> > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-1.16.3-rc1/
> > > > > > > > >>>>>
> > > > > > > > >>>>> [3]
> > https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > > > > > >>>>>
> > > > > > > > >>>>> [4]
> > > > > > > > >>>>>
> > > > > > > > >>
> > > > > > >
> > > >
> > https://repository.apache.org/content/repositories/orgapacheflink-1670/
> > > > > > > > >>>>>
> > > > > > > > >>>>> [5]
> > > > > > >
> https://github.com/apache/flink/releases/tag/release-1.16.3-rc1
> > > > > > > > >>>>>
> > > > > > > > >>>>> [6] https://github.com/apache/flink-web/pull/698
> > > > > > > > >>>>>
> > > > > > > > >>>>> Thanks,
> > > > > > > > >>>>> Release Manager
> > > > > > > > >>>>>
> > > > > > > > >>>>
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Best regards,
> > > > > > > > > Sergey
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > >
> > >
> >
>
