Hi danny , +1 (non binding)
Release notes look good - Signatures and checksums verified - pom versions checked - Source build and tests verified Bests, Samrat On Wed, 29 Nov 2023 at 12:11 PM, Leonard Xu <xbjt...@gmail.com> wrote: > Thanks Danny for driving this, sorry for late verification. > > +1 (binding) > > - built from source code succeeded > - verified signatures > - verified hashsums > - checked the contents contains jar and pom files in apache repo > - checked Github release tag > - reviewed the web PR with minor comment > > Best, > Leonard > > > > > 2023年11月27日 上午1:13，Ahmed Hamdy <hamdy10...@gmail.com> 写道： > > > > Hi Danny > > +1 (non-binding) > > > > > > - Verified signatures and checksums > > - verified no binaries exists in archive > > - built source > > - reviewed web PR > > - Ran E2E example with Kinesis, Firehose & DynamoDB datastream > connectors. > > > > Best Regards > > Ahmed Hamdy > > > > > > On Fri, 24 Nov 2023 at 08:38, Martijn Visser <martijnvis...@apache.org> > > wrote: > > > >> Hi Danny, > >> > >> Thanks for driving this. > >> > >> +1 (binding) > >> > >> - Validated hashes > >> - Verified signature > >> - Verified that no binaries exist in the source archive > >> - Build the source with Maven > >> - Verified licenses > >> - Verified web PRs > >> > >> On Mon, Nov 20, 2023 at 12:29 PM Jiabao Sun > >> <jiabao....@xtransfer.cn.invalid> wrote: > >>> > >>> Thanks Danny for driving the release, > >>> > >>> +1 (non-binding) > >>> > >>> - built from source code succeeded > >>> - verified signatures > >>> - verified hashsums > >>> - checked release notes > >>> > >>> Best, > >>> Jiabao > >>> > >>> > >>>> 2023年11月20日 19:11，Danny Cranmer <dannycran...@apache.org> 写道： > >>>> > >>>> Hello all, > >>>> > >>>> +1 (binding). > >>>> > >>>> - Release notes look good > >>>> - Signatures and checksums match > >>>> - There are no binaries in the source archive > >>>> - pom versions are correct > >>>> - Tag is present in Github > >>>> - CI passes against FLink 1.17 and 1.18 > >>>> - Source build and tests pass > >>>> > >>>> Thanks, > >>>> Danny > >>>> > >>>> On Wed, Nov 1, 2023 at 1:15 AM mystic lama <mysticlama...@gmail.com> > >> wrote: > >>>> > >>>>> +1 (non-binding) > >>>>> > >>>>> - validated shasum > >>>>> - verified build > >>>>> - Java 8 - build good and all test cases pass > >>>>> - Java 11 - build good and all test cases pass > >>>>> > >>>>> Observations: got test failures with Java 17, something to look for > in > >>>>> future > >>>>> > >>>>> On Tue, 31 Oct 2023 at 08:42, Danny Cranmer <dannycran...@apache.org > > > >>>>> wrote: > >>>>> > >>>>>> Hi everyone, > >>>>>> > >>>>>> Please review and vote on release candidate #1 for the version > >> 4.2.0, as > >>>>>> follows: > >>>>>> [ ] +1, Approve the release > >>>>>> [ ] -1, Do not approve the release (please provide specific > comments) > >>>>>> > >>>>>> The complete staging area is available for your review, which > >> includes: > >>>>>> * JIRA release notes [1], > >>>>>> * the official Apache source release to be deployed to > >> dist.apache.org > >>>>>> [2], > >>>>>> which are signed with the key with fingerprint > >>>>>> 0F79F2AFB2351BC29678544591F9C1EC125FD8DB [3], > >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>>>> * source code tag v4.2.0-rc1 [5], > >>>>>> * website pull request listing the new release [6]. > >>>>>> * A link to the CI run on the release tag [7] > >>>>>> > >>>>>> The vote will be open for at least 72 hours. It is adopted by > >> majority > >>>>>> approval, with at least 3 PMC affirmative votes. > >>>>>> > >>>>>> Thanks, > >>>>>> Danny > >>>>>> > >>>>>> [1] > >>>>>> > >>>>>> > >>>>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353011 > >>>>>> [2] > >>>>>> > >>>>> > >> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-4.2.0-rc1 > >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>> [4] > >>>>>> > >> https://repository.apache.org/content/repositories/orgapacheflink-1665/ > >>>>>> [5] > >>>>> > https://github.com/apache/flink-connector-aws/releases/tag/v4.2.0-rc1 > >>>>>> [6] https://github.com/apache/flink-web/pull/693 > >>>>>> [7] > >>>>> > https://github.com/apache/flink-connector-aws/actions/runs/6707962074 > >>>>>> > >>>>> > >>> > >> > >
