+1 (non-binding) - Validated hashes - Verified signature - Verified tags - Verified no binaries in the source archive - Reviewed web pr and found that there're some conflicts need to be resolved
Best, Jiabao > 2024年1月12日 23:58，Danny Cranmer <dannycran...@apache.org> 写道： > > Apologies I jumped the gun on this one. We only have 2 binding votes. > Reopening the thread. > > On Fri, Jan 12, 2024 at 3:43 PM Danny Cranmer <dannycran...@apache.org> > wrote: > >> Thanks all, this vote is now closed, I will announce the results on a >> separate thread. >> >> Thanks, >> Danny >> >> On Fri, Jan 12, 2024 at 3:43 PM Danny Cranmer <dannycran...@apache.org> >> wrote: >> >>> +1 (binding) >>> >>> - Verified signatures and checksums >>> - Reviewed release notes >>> - Verified no binaries in the source archive >>> - Source builds using Maven >>> - Reviewed NOTICE files (I suppose the copyright needs to be 2024 now!) >>> >>> Thanks, >>> Danny >>> >>> On Fri, Jan 12, 2024 at 12:56 PM Martijn Visser <martijnvis...@apache.org> >>> wrote: >>> >>>> One non blocking nit: the version for flink.version in the main POM is >>>> set to 1.17.1. I think this should be 1.17.0 (since that's the lowest >>>> possible Flink version that's supported). >>>> >>>> +1 (binding) >>>> >>>> - Validated hashes >>>> - Verified signature >>>> - Verified that no binaries exist in the source archive >>>> - Build the source with Maven >>>> - Verified licenses >>>> - Verified web PRs >>>> >>>> On Mon, Jan 1, 2024 at 11:57 AM Danny Cranmer <dannycran...@apache.org> >>>> wrote: >>>>> >>>>> Hey, >>>>> >>>>> Gordon, apologies for the delay. Yes this is the correct >>>> understanding, all >>>>> connectors follow a similar pattern. >>>>> >>>>> Would appreciate some PMC eyes on this release. >>>>> >>>>> Thanks, >>>>> Danny >>>>> >>>>> On Thu, 23 Nov 2023, 23:28 Tzu-Li (Gordon) Tai, <tzuli...@apache.org> >>>> wrote: >>>>> >>>>>> Hi Danny, >>>>>> >>>>>> Thanks for starting a RC for this. >>>>>> >>>>>> From the looks of the staged POMs for 1.1.0-1.18, the flink versions >>>> for >>>>>> Flink dependencies still point to 1.17.1. >>>>>> >>>>>> My understanding is that this is fine, as those provided scope >>>>>> dependencies (e.g. flink-streaming-java) will have their versions >>>>>> overwritten by the user POM if they do intend to compile their jobs >>>> against >>>>>> Flink 1.18.x. >>>>>> Can you clarify if this is the correct understanding of how we >>>> intend the >>>>>> externalized connector artifacts to be published? Related discussion >>>> on >>>>>> [1]. >>>>>> >>>>>> Thanks, >>>>>> Gordon >>>>>> >>>>>> [1] https://lists.apache.org/thread/x1pyrrrq7o1wv1lcdovhzpo4qhd4tvb4 >>>>>> >>>>>> On Thu, Nov 23, 2023 at 3:14 PM Sergey Nuyanzin <snuyan...@gmail.com >>>>> >>>>>> wrote: >>>>>> >>>>>>> +1 (non-binding) >>>>>>> >>>>>>> - downloaded artifacts >>>>>>> - built from source >>>>>>> - verified checksums and signatures >>>>>>> - reviewed web pr >>>>>>> >>>>>>> >>>>>>> On Mon, Nov 6, 2023 at 5:31 PM Ryan Skraba >>>> <ryan.skr...@aiven.io.invalid >>>>>>> >>>>>>> wrote: >>>>>>> >>>>>>>> Hello! +1 (non-binding) Thanks for the release! >>>>>>>> >>>>>>>> I've validated the source for the RC1: >>>>>>>> * flink-connector-opensearch-1.1.0-src.tgz at r64995 >>>>>>>> * The sha512 checksum is OK. >>>>>>>> * The source file is signed correctly. >>>>>>>> * The signature 0F79F2AFB2351BC29678544591F9C1EC125FD8DB is >>>> found in >>>>>> the >>>>>>>> KEYS file, and on https://keyserver.ubuntu.com/ >>>>>>>> * The source file is consistent with the GitHub tag v1.1.0-rc1, >>>> which >>>>>>>> corresponds to commit 0f659cc65131c9ff7c8c35eb91f5189e80414ea1 >>>>>>>> - The files explicitly excluded by create_pristine_sources (such >>>> as >>>>>>>> .gitignore and the submodule tools/releasing/shared) are not >>>> present. >>>>>>>> * Has a LICENSE file and a NOTICE file >>>>>>>> * Does not contain any compiled binaries. >>>>>>>> >>>>>>>> * The sources can be compiled and unit tests pass with >>>> flink.version >>>>>>> 1.17.1 >>>>>>>> and flink.version 1.18.0 >>>>>>>> >>>>>>>> * Nexus has three staged artifact ids for 1.1.0-1.17 and >>>> 1.1.0-1.18 >>>>>>>> - flink-connector-opensearch (.jar, -javadoc.jar, -sources.jar, >>>>>>>> -tests.jar and .pom) >>>>>>>> - flink-sql-connector-opensearch (.jar, -sources.jar and .pom) >>>>>>>> - flink-connector-gcp-pubsub-parent (only .pom) >>>>>>>> >>>>>>>> All my best, Ryan >>>>>>>> >>>>>>>> On Fri, Nov 3, 2023 at 10:29 AM Danny Cranmer < >>>> dannycran...@apache.org >>>>>>> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Hi everyone, >>>>>>>>> >>>>>>>>> Please review and vote on the release candidate #1 for the >>>> version >>>>>>> 1.1.0 >>>>>>>> of >>>>>>>>> flink-connector-opensearch, as follows: >>>>>>>>> [ ] +1, Approve the release >>>>>>>>> [ ] -1, Do not approve the release (please provide specific >>>> comments) >>>>>>>>> >>>>>>>>> >>>>>>>>> The complete staging area is available for your review, which >>>>>> includes: >>>>>>>>> * JIRA release notes [1], >>>>>>>>> * the official Apache source release to be deployed to >>>>>> dist.apache.org >>>>>>>> [2], >>>>>>>>> which are signed with the key with fingerprint >>>>>>>>> 0F79F2AFB2351BC29678544591F9C1EC125FD8DB [3], >>>>>>>>> * all artifacts to be deployed to the Maven Central Repository >>>> [4], >>>>>>>>> * source code tag v1.1.0-rc1 [5], >>>>>>>>> * website pull request listing the new release [6]. >>>>>>>>> >>>>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>>> majority >>>>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Danny >>>>>>>>> >>>>>>>>> [1] >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353141 >>>>>>>>> [2] >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>> https://dist.apache.org/repos/dist/dev/flink/flink-connector-opensearch-1.1.0-rc1/ >>>>>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>>>>>>>> [4] >>>>>>>> >>>>>> >>>> https://repository.apache.org/content/repositories/orgapacheflink-1666/ >>>>>>>>> [5] >>>>>>> >>>> https://github.com/apache/flink-connector-opensearch/tree/v1.1.0-rc1 >>>>>>>>> [6] https://github.com/apache/flink-web/pull/694 >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Best regards, >>>>>>> Sergey >>>>>>> >>>>>> >>>> >>>
