Thanks Hang for the review! We should use jdk8 to compile the jar, I will cancel the rc1 and prepare rc2 soon.
Best, Leonard > 2024年1月30日 下午2:39,Hang Ruan <ruanhang1...@gmail.com> 写道: > > Hi, Leonard. > > I find that META-INF/MANIFEST.MF in > flink-sql-connector-mongodb-1.1.0-1.18.jar shows as follow. > > Manifest-Version: 1.0 > Archiver-Version: Plexus Archiver > Created-By: Apache Maven 3.8.1 > Built-By: bangjiangxu > Build-Jdk: 11.0.11 > Specification-Title: Flink : Connectors : SQL : MongoDB > Specification-Version: 1.1.0-1.18 > Specification-Vendor: The Apache Software Foundation > Implementation-Title: Flink : Connectors : SQL : MongoDB > Implementation-Version: 1.1.0-1.18 > Implementation-Vendor-Id: org.apache.flink > Implementation-Vendor: The Apache Software Foundation > > Maybe we should build mongodb connector with jdk8. > > Best, > Hang > > Jiabao Sun <jiabao....@xtransfer.cn.invalid> 于2024年1月29日周一 21:51写道: > >> Thanks Leonard for driving this. >> >> +1(non-binding) >> >> - Release notes look good >> - Tag is present in Github >> - Validated checksum hash >> - Verified signature >> - Build the source with Maven by jdk8,11,17,21 >> - Verified web PR and left minor comments >> - Run a filter push down test by sql-client on Flink 1.18.1 and it works >> well >> >> Best, >> Jiabao >> >> >> On 2024/01/29 12:33:23 Leonard Xu wrote: >>> Hey all, >>> >>> Please help review and vote on the release candidate #1 for the version >> 1.1.0 of the >>> Apache Flink MongoDB Connector as follows: >>> >>> [ ] +1, Approve the release >>> [ ] -1, Do not approve the release (please provide specific comments) >>> >>> The complete staging area is available for your review, which includes: >>> * JIRA release notes [1], >>> * The official Apache source release to be deployed to dist.apache.org >> [2], >>> which are signed with the key with fingerprint >>> 5B2F6608732389AEB67331F5B197E1F1108998AD [3], >>> * All artifacts to be deployed to the Maven Central Repository [4], >>> * Source code tag v.1.0-rc1 [5], >>> * Website pull request listing the new release [6]. >>> >>> The vote will be open for at least 72 hours. It is adopted by majority >>> approval, with at least 3 PMC affirmative votes. >>> >>> >>> Best, >>> Leonard >>> [1] >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12353483 >>> [2] >> https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.1.0-rc1/ >>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS >>> [4] >> https://repository.apache.org/content/repositories/orgapacheflink-1702/ >>> [5] https://github.com/apache/flink-connector-mongodb/tree/v1.1.0-rc1 >>> [6] https://github.com/apache/flink-web/pull/719