Thank you Jeyhun, Leonard, and Hang for your comments! Let me address them from earliest to latest.
> How do you plan the review process in this case (e.g. incremental over existing codebase or cumulative all at once) ? I think incremental would be less time consuming and complex for reviewers so I would leaning towards that direction. I would imagine multiple subtasks for migrating the existing code, and updating the deprecated interfaces, so those should be separate PRs and the release can be initiated when everything is merged. > (1) About the release version, could you specify kudu connector version > instead of flink version 1.18 as external connector version is different with > flink? > (2) About the connector config options, could you enumerate these options so > that we can review they’re reasonable or not? I added these to the FLIP, copied the current configs options as is, PTAL. > (3) Metrics is also key part of connector, could you add the supported > connector metrics to public interface as well? The current Bahir conenctor code does not include any metrics and I did not plan to include them into the scope of this FLIP. > I think that how to state this code originally lived in Bahir may be in the FLIP. I might miss your point, but the FLIP contains this: "Migrating the current code keeping the history and noting it explicitly it was forked from the Bahir repository [2]." Pls. share if you meant something else. Best, Ferenc On Friday, March 8th, 2024 at 10:42, Hang Ruan <ruanhang1...@gmail.com> wrote: > > > Hi, Ferenc. > > Thanks for the FLIP discussion. +1 for the proposal. > I think that how to state this code originally lived in Bahir may be in the > FLIP. > > Best, > Hang > > Leonard Xu xbjt...@gmail.com 于2024年3月7日周四 14:14写道: > > > Thanks Ferenc for kicking off this discussion, I left some comments here: > > > > (1) About the release version, could you specify kudu connector version > > instead of flink version 1.18 as external connector version is different > > with flink ? > > > > (2) About the connector config options, could you enumerate these options > > so that we can review they’re reasonable or not? > > > > (3) Metrics is also key part of connector, could you add the supported > > connector metrics to public interface as well? > > > > Best, > > Leonard > > > > > 2024年3月6日 下午11:23,Ferenc Csaky ferenc.cs...@pm.me.INVALID 写道: > > > > > > Hello devs, > > > > > > Opening this thread to discuss a FLIP [1] about externalizing the Kudu > > > connector, as recently > > > the Apache Bahir project were moved to the attic [2]. Some details were > > > discussed already > > > in another thread [3]. I am proposing to externalize this connector and > > > keep it maintainable, > > > and up to date. > > > > > > Best regards, > > > Ferenc > > > > > > [1] > > > https://docs.google.com/document/d/1vHF_uVe0FTYCb6PRVStovqDeqb_C_FKjt2P5xXa7uhE > > > [2] https://bahir.apache.org/ > > > [3] https://lists.apache.org/thread/2nb8dxxfznkyl4hlhdm3vkomm8rk4oyq