+1 (binding) As per Gyula's suggestion above verified with " ghcr.io/apache/flink-kubernetes-operator:91d67d9 ".
- Verified Helm repo works as expected, points to correct image tag, build, version - Verified basic examples + checked operator logs everything looks as expected - Verified hashes, signatures and source release contains no binaries - Ran built-in tests, built jars + docker image from source successfully - Upgraded the operator and the CRD from 1.7.0 to 1.8.0 Best, Marton On Wed, Mar 20, 2024 at 9:10 PM Mate Czagany <czmat...@gmail.com> wrote: > Hi, > > +1 (non-binding) > > - Verified checksums > - Verified signatures > - Verified no binaries in source distribution > - Verified Apache License and NOTICE files > - Executed tests > - Built container image > - Verified chart version and appVersion matches > - Verified Helm chart can be installed with default values > - Verify that RC repo works as Helm repo > > Best Regards, > Mate > > Alexander Fedulov <alexander.fedu...@gmail.com> ezt írta (időpont: 2024. > márc. 19., K, 23:10): > > > Hi Max, > > > > +1 > > > > - Verified SHA checksums > > - Verified GPG signatures > > - Verified that the source distributions do not contain binaries > > - Verified built-in tests (mvn clean verify) > > - Verified build with Java 11 (mvn clean install -DskipTests -T 1C) > > - Verified that Helm and operator files contain Apache licenses (rg -L > > --files-without-match "http://www.apache.org/licenses/LICENSE-2.0"; .). > > I am not sure we need to > > include ./examples/flink-beam-example/dependency-reduced-pom.xml > > and ./flink-autoscaler-standalone/dependency-reduced-pom.xml though > > - Verified that chart and appVersion matches the target release (91d67d9) > > - Verified that Helm chart can be installed from the local Helm folder > > without overriding any parameters > > - Verified that Helm chart can be installed from the RC repo without > > overriding any parameters ( > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.8.0-rc1 > > ) > > - Verified docker container build > > > > Best, > > Alex > > > > > > On Mon, 18 Mar 2024 at 20:50, Maximilian Michels <m...@apache.org> wrote: > > > > > @Rui @Gyula Thanks for checking the release! > > > > > > >A minor correction is that [3] in the email should point to: > > > >ghcr.io/apache/flink-kubernetes-operator:91d67d9 . But the helm chart > > and > > > > everything is correct. It's a typo in the vote email. > > > > > > Good catch. Indeed, for the linked Docker image 8938658 points to > > > HEAD^ of the rc branch, 91d67d9 is the HEAD. There are no code changes > > > between those two commits, except for updating the version. So the > > > votes are not impacted, especially because votes are casted against > > > the source release which, as you pointed out, contains the correct > > > image ref. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, Mar 18, 2024 at 9:54 AM Gyula Fóra <gyula.f...@gmail.com> > wrote: > > > > > > > > Hi Max! > > > > > > > > +1 (binding) > > > > > > > > - Verified source release, helm chart + checkpoints / signatures > > > > - Helm points to correct image > > > > - Deployed operator, stateful example and executed upgrade + > savepoint > > > > redeploy > > > > - Verified logs > > > > - Flink web PR looks good +1 > > > > > > > > A minor correction is that [3] in the email should point to: > > > > ghcr.io/apache/flink-kubernetes-operator:91d67d9 . But the helm > chart > > > and > > > > everything is correct. It's a typo in the vote email. > > > > > > > > Thank you for preparing the release! > > > > > > > > Cheers, > > > > Gyula > > > > > > > > On Mon, Mar 18, 2024 at 8:26 AM Rui Fan <1996fan...@gmail.com> > wrote: > > > > > > > > > Thanks Max for driving this release! > > > > > > > > > > +1(non-binding) > > > > > > > > > > - Downloaded artifacts from dist ( svn co > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.8.0-rc1/ > > > > > ) > > > > > - Verified SHA512 checksums : ( for i in *.tgz; do echo $i; > sha512sum > > > > > --check $i.sha512; done ) > > > > > - Verified GPG signatures : ( $ for i in *.tgz; do echo $i; gpg > > > --verify > > > > > $i.asc $i ) > > > > > - Build the source with java-11 and java-17 ( mvn -T 20 clean > install > > > > > -DskipTests ) > > > > > - Verified the license header during build the source > > > > > - Verified that chart and appVersion matches the target release > (less > > > the > > > > > index.yaml and Chart.yaml ) > > > > > - RC repo works as Helm repo( helm repo add > > > flink-operator-repo-1.8.0-rc1 > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.8.0-rc1/ > > > > > ) > > > > > - Verified Helm chart can be installed ( helm install > > > > > flink-kubernetes-operator > > > > > flink-operator-repo-1.8.0-rc1/flink-kubernetes-operator --set > > > > > webhook.create=false ) > > > > > - Submitted the autoscaling demo, the autoscaler works well with > > > *memory > > > > > tuning *(kubectl apply -f autoscaling.yaml) > > > > > - job.autoscaler.memory.tuning.enabled: "true" > > > > > - Download Autoscaler standalone: wget > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1710/org/apache/flink/flink-autoscaler-standalone/1.8.0/flink-autoscaler-standalone-1.8.0.jar > > > > > - Ran Autoscaler standalone locally, it works well with rescale api > > and > > > > > JDBC state store/event handler > > > > > > > > > > Best, > > > > > Rui > > > > > > > > > > On Fri, Mar 15, 2024 at 1:45 AM Maximilian Michels <m...@apache.org > > > > > wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Please review and vote on the release candidate #1 for the > version > > > > > > 1.8.0 of the Apache Flink Kubernetes Operator, as follows: > > > > > > > > > > > > [ ] +1, Approve the release > > > > > > [ ] -1, Do not approve the release (please provide specific > > comments) > > > > > > > > > > > > **Release Overview** > > > > > > > > > > > > As an overview, the release consists of the following: > > > > > > a) Kubernetes Operator canonical source distribution (including > the > > > > > > Dockerfile), to be deployed to the release repository at > > > > > > dist.apache.org > > > > > > b) Kubernetes Operator Helm Chart to be deployed to the release > > > > > > repository at dist.apache.org > > > > > > c) Maven artifacts to be deployed to the Maven Central Repository > > > > > > d) Docker image to be pushed to Dockerhub > > > > > > > > > > > > **Staging Areas to Review** > > > > > > > > > > > > The staging areas containing the above mentioned artifacts are as > > > > > > follows, for your review: > > > > > > * All artifacts for (a), (b) can be found in the corresponding > dev > > > > > > repository at dist.apache.org [1] > > > > > > * All artifacts for (c) can be found at the Apache Nexus > Repository > > > [2] > > > > > > * The docker image for (d) is staged on github [3] > > > > > > > > > > > > All artifacts are signed with the key > > > > > > DA359CBFCEB13FC302A8793FB655E6F7693D5FDE [4] > > > > > > > > > > > > Other links for your review: > > > > > > * JIRA release notes [5] > > > > > > * source code tag "release-1.8.0-rc1" [6] > > > > > > * PR to update the website Downloads page to include Kubernetes > > > > > > Operator links [7] > > > > > > > > > > > > **Vote Duration** > > > > > > > > > > > > The voting time will run for at least 72 hours. It is adopted by > > > > > > majority approval, with at least 3 PMC affirmative votes. > > > > > > > > > > > > **Note on Verification** > > > > > > > > > > > > You can follow the basic verification guide here [8]. Note that > you > > > > > > don't need to verify everything yourself, but please make note of > > > what > > > > > > you have tested together with your +- vote. > > > > > > > > > > > > Thanks, > > > > > > Max > > > > > > > > > > > > [1] > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/flink/flink-kubernetes-operator-1.8.0-rc1/ > > > > > > [2] > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheflink-1710/ > > > > > > [3] ghcr.io/apache/flink-kubernetes-operator:8938658 > > > > > > [4] https://dist.apache.org/repos/dist/release/flink/KEYS > > > > > > [5] > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353866&projectId=12315522 > > > > > > [6] > > > > > > > > > > > > > > > > > https://github.com/apache/flink-kubernetes-operator/tree/release-1.8.0-rc1 > > > > > > [7] https://github.com/apache/flink-web/pull/726 > > > > > > [8] > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/Verifying+a+Flink+Kubernetes+Operator+Release > > > > > > > > > > > > > > > > >
