Hi Ferenc, Thank you for your comments, I have updated the Google docs with a new section for the new configs. All of the newly added config keys will have defaults set, and by default all the savepoint/checkpoint operations will use the old system: write their results to the FlinkDeployment/FlinkSessionJob status field.
I have also added a default for the checkpoint type to be FULL (which is also the default currently). That was an oversight on my part to miss that. Regards, Mate Ferenc Csaky <ferenc.cs...@pm.me.invalid> ezt írta (időpont: 2024. ápr. 16., K, 16:10): > Thank you Mate for initiating this discussion. +1 for this idea. > Some Qs: > > Can you specify the newly introduced configurations in more > details? Currently, it is not fully clear to me what are the > possible values of `kubernetes.operator.periodic.savepoint.mode`, > is it optional, has a default value? > > I see that in `SavepointSpec.formatType` has a default, although > `CheckppointSpec.checkpointType` not. Are we inferring that from > the config? My point is, in general I think it would be good to > handle the two snapshot types in a similar way when it makes sense > to minimize any kind of confusion. > > Best, > Ferenc > > > > On Tuesday, April 16th, 2024 at 11:34, Mate Czagany <czmat...@gmail.com> > wrote: > > > > > > > Hi Everyone, > > > > I would like to start a discussion on FLIP-446: Kubernetes Operator State > > Snapshot CRD. > > > > This FLIP adds a new custom resource for Operator users to create and > > manage their savepoints and checkpoints. I have also developed an initial > > POC to prove that this approach is feasible, you can find the link for > that > > in the FLIP. > > > > There is a Confluence page [1] and a Google Docs page [2] as I do not > have > > a Confluence account yet. > > > > [1] > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-446%3A+Kubernetes+Operator+State+Snapshot+CRD > > [2] > > > https://docs.google.com/document/d/1VdfLFaE4i6ESbCQ38CH7TKOiPQVvXeOxNV2FeSMnOTg > > > > > > Regards, > > Mate >
