Hi, Yue. Very glad to see that IngestDB will be used to improve the rescaling performance of RocksDB. And +1 for the upgrade. Thanks for the great work!
On Thu, Apr 25, 2024 at 5:16 AM Martijn Visser <martijnvis...@apache.org> wrote: > +1 > > On Wed, Apr 24, 2024 at 5:31 PM Congxian Qiu <qcx978132...@gmail.com> > wrote: > > > Thanks for driving this, yue > > > > We also observed significant performance improvements in some cases after > > bumped the Rocksdb version, +1 for this work > > > > Best, > > Congxian > > > > > > yue ma <mayuefi...@gmail.com> 于2024年4月24日周三 19:16写道： > > > > > hi Yanfei, > > > > > > Thanks for your feedback and reminders I have updated related > > information. > > > In fact, most of them use the default Configrations. > > > > > > Yanfei Lei <fredia...@gmail.com> 于2024年4月23日周二 12:51写道： > > > > > > > Hi Yue & Roman, > > > > > > > > Thanks for initiating this FLIP and all the efforts for the upgrade. > > > > > > > > 8.10.0 introduces some new features, making it possible for Flink to > > > > implement some new exciting features, and the upgrade also makes > > > > FRocksDB easier to maintain, +1 for upgrading. > > > > > > > > I read the FLIP and have a minor comment, it would be better to add > > > > some description about the environment/configuration of the nexmark's > > > > result. > > > > > > > > Roman Khachatryan <ro...@apache.org> 于2024年4月23日周二 12:07写道： > > > > > > > > > > > > > > Hi, > > > > > > > > > > Thanks for writing the proposal and preparing the upgrade. > > > > > > > > > > FRocksDB definitely needs to be kept in sync with the upstream and > > the > > > > new > > > > > APIs are necessary for faster rescaling. > > > > > We're already using a similar version internally. > > > > > > > > > > I reviewed the FLIP and it looks good to me (disclaimer: I took > part > > in > > > > > some steps of this effort). > > > > > > > > > > > > > > > Regards, > > > > > Roman > > > > > > > > > > On Mon, Apr 22, 2024, 08:11 yue ma <mayuefi...@gmail.com> wrote: > > > > > > > > > > > Hi Flink devs, > > > > > > > > > > > > I would like to start a discussion on FLIP-447: Upgrade FRocksDB > > from > > > > > > 6.20.3 to 8.10.0 > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-447%3A+Upgrade+FRocksDB+from+6.20.3++to+8.10.0 > > > > > > > > > > > > This FLIP proposes upgrading the version of FRocksDB in the Flink > > > > Project > > > > > > from 6.20.3 to 8.10.0. > > > > > > The FLIP mainly introduces the main benefits of upgrading > FRocksDB, > > > > > > including the use of IngestDB which can improve Rescaling > > performance > > > > by > > > > > > more than 10 times in certain scenarios, as well as other > potential > > > > > > optimization points such as async_io, blob db, and tiered > > storage.The > > > > > > FLIP also presented test results based on RocksDB 8.10, including > > > > > > StateBenchmark and Nexmark tests. > > > > > > Overall, upgrading FRocksDB may result in a small regression of > > write > > > > > > performance( which is a very small part of the overall overhead), > > but > > > > it > > > > > > can bring many important performance benefits. > > > > > > So we hope to upgrade the version of FRocksDB through this FLIP. > > > > > > > > > > > > Looking forward to everyone's feedback and suggestions. Thank > you! > > > > > > -- > > > > > > Best regards, > > > > > > Yue > > > > > > > > > > > > > > > > > > > > > > -- > > > > Best, > > > > Yanfei > > > > > > > > > > > > > -- > > > Best, > > > Yue > > > > > > -- Best, Hangxiang.
