Hi Martijn Thanks for the proposal +1 from me. Should this change take place in 1.20, what are the planned release steps for connectors that only offer a deprecated interface in this case (i.e. RabbitMQ, Cassandra, pusbub, Hbase)? Are we going to refrain from releases that support 1.20+ till the blockers are implemented? Best Regards Ahmed Hamdy
On Fri, 3 May 2024 at 14:32, Péter Váry <peter.vary.apa...@gmail.com> wrote: > > With regards to FLINK-35149, the fix version indicates a change at Flink > CDC; is that indeed correct, or does it require a change in the SinkV2 > interface? > > The fix doesn't need change in SinkV2, so we are good there. > The issue is that the new SinkV2 SupportsCommitter/SupportsPreWriteTopology > doesn't work with the CDC yet. > > Martijn Visser <martijnvis...@apache.org> ezt írta (időpont: 2024. máj. > 3., > P, 14:06): > > > Hi Ferenc, > > > > You're right, 1.20 it is :) > > > > I've assigned the HBase one to you! > > > > Thanks, > > > > Martijn > > > > On Fri, May 3, 2024 at 1:55 PM Ferenc Csaky <ferenc.cs...@pm.me.invalid> > > wrote: > > > > > Hi Martijn, > > > > > > +1 for the proposal. > > > > > > > targeted for Flink 1.19 > > > > > > I guess you meant Flink 1.20 here. > > > > > > Also, I volunteer to take updating the HBase sink, feel free to assign > > > that task to me. > > > > > > Best, > > > Ferenc > > > > > > > > > > > > > > > On Friday, May 3rd, 2024 at 10:20, Martijn Visser < > > > martijnvis...@apache.org> wrote: > > > > > > > > > > > > > > > Hi Peter, > > > > > > > > I'll add it for completeness, thanks! > > > > With regards to FLINK-35149, the fix version indicates a change at > > Flink > > > > CDC; is that indeed correct, or does it require a change in the > SinkV2 > > > > interface? > > > > > > > > Best regards, > > > > > > > > Martijn > > > > > > > > > > > > On Fri, May 3, 2024 at 7:47 AM Péter Váry > peter.vary.apa...@gmail.com > > > > > > > > wrote: > > > > > > > > > Hi Martijn, > > > > > > > > > > We might want to add FLIP-371 [1] to the list. (Or we aim only for > > > higher > > > > > level FLIPs?) > > > > > > > > > > We are in the process of using the new API in Iceberg connector > [2] - > > > so > > > > > far, so good. > > > > > > > > > > I know of one minor known issue about the sink [3], which should be > > > ready > > > > > for the release. > > > > > > > > > > All-in-all, I think we are in good shape, and we could move forward > > > with > > > > > the promotion. > > > > > > > > > > Thanks, > > > > > Peter > > > > > > > > > > [1] - > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=263430387 > > > > > [2] - https://github.com/apache/iceberg/pull/10179 > > > > > [3] - https://issues.apache.org/jira/browse/FLINK-35149 > > > > > > > > > > On Thu, May 2, 2024, 09:47 Muhammet Orazov > > > mor+fl...@morazow.com.invalid > > > > > wrote: > > > > > > > > > > > Got it, thanks! > > > > > > > > > > > > On 2024-05-02 06:53, Martijn Visser wrote: > > > > > > > > > > > > > Hi Muhammet, > > > > > > > > > > > > > > Thanks for joining the discussion! The changes in this FLIP > would > > > be > > > > > > > targeted for Flink 1.19, since it's only a matter of changing > the > > > > > > > annotation. > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > Martijn > > > > > > > > > > > > > > On Thu, May 2, 2024 at 7:26 AM Muhammet Orazov > > > mor+fl...@morazow.com > > > > > > > wrote: > > > > > > > > > > > > > > > Hello Martijn, > > > > > > > > > > > > > > > > Thanks for the FLIP and detailed history of changes, +1. > > > > > > > > > > > > > > > > Would FLIP changes target for 2.0? I think it would be good > > > > > > > > to have clear APIs on 2.0 release. > > > > > > > > > > > > > > > > Best, > > > > > > > > Muhammet > > > > > > > > > > > > > > > > On 2024-05-01 15:30, Martijn Visser wrote: > > > > > > > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > > > > > > > I would like to start a discussion on FLIP-453: Promote > > > Unified Sink > > > > > > > > > API V2 > > > > > > > > > to Public and Deprecate SinkFunction > > > > > > > > > https://cwiki.apache.org/confluence/x/rIobEg > > > > > > > > > > > > > > > > > > This FLIP proposes to promote the Unified Sink API V2 from > > > > > > > > > PublicEvolving > > > > > > > > > to Public and to mark the SinkFunction as Deprecated. > > > > > > > > > > > > > > > > > > I'm looking forward to your thoughts. > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > > > > > Martijn > > > > > >
