Hello all, Thanks for Driving this David. I am +1 for adding support for the new format, however have some questions/suggestions on the details.
1. Passing around Map<String, Object> additionalInputProperties feels a bit dirty. It looks like this is mainly for the Kafka connector. This connector already has a de/serialization schema extension to access record headers, KafkaRecordDeserializationSchema [1], can we use this instead? 2. Can you elaborate why we need to change the SchemaCoder interface? Again I am not a fan of adding these Map parameters 3. I assume this integration will go into the core Flink repo under flink-formats [2], and not be a separate repository like the connectors? Thanks, Danny [1] https://github.com/apache/flink-connector-kafka/blob/main/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/deserializer/KafkaRecordDeserializationSchema.java [2] https://github.com/apache/flink/tree/master/flink-formats On Sat, May 4, 2024 at 12:46 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: > +1 (non-binding) > > Best Regards > Ahmed Hamdy > > > On Fri, 3 May 2024 at 15:16, Jeyhun Karimov <je.kari...@gmail.com> wrote: > > > +1 (non binding) > > > > Thanks for driving this FLIP David. > > > > Regards, > > Jeyhun > > > > On Fri, May 3, 2024 at 2:21 PM Mark Nuttall <mnutt...@apache.org> wrote: > > > > > +1, I would also like to see first class support for Avro and Apicurio > > > > > > -- Mark Nuttall, mnutt...@apache.org > > > Senior Software Engineer, IBM Event Automation > > > > > > On 2024/05/02 09:41:09 David Radley wrote: > > > > Hi everyone, > > > > > > > > I'd like to start a vote on the FLIP-454: New Apicurio Avro format > > > > [1]. The discussion thread is here [2]. > > > > > > > > The vote will be open for at least 72 hours unless there is an > > > > objection > > > > or > > > > insufficient votes. > > > > > > > > [1] > > > > > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-454%3A+New+Apicurio+Avro+format > > > > [2] https://lists.apache.org/thread/wtkl4yn847tdd0wrqm5xgv9wc0cb0kr8 > > > > > > > > > > > > Kind regards, David. > > > > > > > > Unless otherwise stated above: > > > > > > > > IBM United Kingdom Limited > > > > Registered in England and Wales with number 741598 > > > > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 > 3AU > > > > > > > > > >
