+1 (binding) - Release notes look good - Source archive checksum and signature is correct - Binary checksum and signature is correct - Contents of Maven repo looks good - Verified there are no binaries in the source archive - Builds from source, tests pass using Java 8 - CI run passed - Tag exists in repo - NOTICE and LICENSE files present and correct
Thanks, Danny On Wed, May 22, 2024 at 1:29 PM Leonard Xu <xbjt...@gmail.com> wrote: > +1 (binding) > > - verified signatures > - verified hashsums > - built from source code with java 1.8 succeeded > - checked Github release tag > - checked release notes > - reviewed the web PR > > Best, > Leonard > > > 2024年5月22日 下午4:16，Qingsheng Ren <re...@apache.org> 写道： > > > > +1 (binding) > > > > - Verified checksum and signature > > - Built from source with Java 8 > > - Verified source release contains no binaries > > - Verified tag exists on GitHub > > - Verified JARs on Maven repo is built by Java 8 > > - Reviewed web PR > > > > Thanks for the awesome work, Danny! > > > > Best, > > Qingsheng > > > > On Mon, May 20, 2024 at 2:53 PM Jiabao Sun <jiabao...@apache.org> wrote: > >> > >> We need more votes for this release. > >> Much appreciated for helping with this release verification. > >> > >> Best, > >> Jiabao > >> > >> Jiabao Sun <jiabao...@apache.org> 于2024年4月21日周日 21:35写道： > >> > >>> +1 (non-binding) > >>> > >>> - Validated checksum hash > >>> - Verified signature > >>> - Tag is present > >>> - Build successful with jdk8, jdk11 and jdk17 > >>> - Checked the dist jar was built by jdk8 > >>> - Reviewed web PR > >>> Best, > >>> Jiabao > >>> > >>> Hang Ruan <ruanhang1...@gmail.com> 于2024年4月21日周日 21:33写道： > >>> > >>>> +1 (non-binding) > >>>> > >>>> - Validated checksum hash > >>>> - Verified signature > >>>> - Verified that no binaries exist in the source archive > >>>> - Build the source with Maven and jdk8 > >>>> - Verified web PR > >>>> - Check that the jar is built by jdk8 > >>>> > >>>> Best, > >>>> Hang > >>>> > >>>> Ahmed Hamdy <hamdy10...@gmail.com> 于2024年4月18日周四 21:40写道： > >>>> > >>>>> +1 (non-binding) > >>>>> > >>>>> - verified hashes and checksums > >>>>> - verified signature > >>>>> - verified source contains no binaries > >>>>> - tag exists in github > >>>>> - reviewed web PR > >>>>> > >>>>> > >>>>> Best Regards > >>>>> Ahmed Hamdy > >>>>> > >>>>> > >>>>> On Thu, 18 Apr 2024 at 11:21, Danny Cranmer <dannycran...@apache.org > > > >>>>> wrote: > >>>>> > >>>>>> Hi everyone, > >>>>>> > >>>>>> Please review and vote on the release candidate #2 for v1.2.0, as > >>>>> follows: > >>>>>> [ ] +1, Approve the release > >>>>>> [ ] -1, Do not approve the release (please provide specific > comments) > >>>>>> > >>>>>> This release supports Flink 1.18 and 1.19. > >>>>>> > >>>>>> The complete staging area is available for your review, which > >>>> includes: > >>>>>> * JIRA release notes [1], > >>>>>> * the official Apache source release to be deployed to > >>>> dist.apache.org > >>>>>> [2], > >>>>>> which are signed with the key with fingerprint 125FD8DB [3], > >>>>>> * all artifacts to be deployed to the Maven Central Repository [4], > >>>>>> * source code tag v1.2.0-rc2 [5], > >>>>>> * website pull request listing the new release [6]. > >>>>>> * CI build of tag [7]. > >>>>>> > >>>>>> The vote will be open for at least 72 hours. It is adopted by > majority > >>>>>> approval, with at least 3 PMC affirmative votes. > >>>>>> > >>>>>> Thanks, > >>>>>> Danny > >>>>>> > >>>>>> [1] > >>>>>> > >>>>>> > >>>>> > >>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12354192 > >>>>>> [2] > >>>>>> > >>>>>> > >>>>> > >>>> > https://dist.apache.org/repos/dist/dev/flink/flink-connector-mongodb-1.2.0-rc2 > >>>>>> [3] https://dist.apache.org/repos/dist/release/flink/KEYS > >>>>>> [4] > >>>>>> > >>>> > https://repository.apache.org/content/repositories/orgapacheflink-1719/ > >>>>>> [5] > >>>>>> > >>>>> > >>>> > https://github.com/apache/flink-connector-mongodb/releases/tag/v1.2.0-rc2 > >>>>>> [6] https://github.com/apache/flink-web/pull/735 > >>>>>> [7] > >>>>>> > >>>>> > >>>> > https://github.com/apache/flink-connector-mongodb/actions/runs/8735987710 > >>>>>> > >>>>> > >>>> > >>> > >
