Ramin Gharib created FLINK-39866:
------------------------------------
Summary: Remove dead KEYVALUE code from SqlFunctionUtils and
StringCallGen
Key: FLINK-39866
URL: https://issues.apache.org/jira/browse/FLINK-39866
Project: Flink
Issue Type: Improvement
Components: Table SQL / Planner, Table SQL / Runtime
Reporter: Ramin Gharib
Assignee: Ramin Gharib
The {{KEYVALUE}} codepath is orphaned. There is no SQL operator for it, no
codegen dispatch, and no documentation. {{StringCallGen.generateKeyValue}} has
no callers, so neither {{SqlFunctionUtils.keyValue}} overload (the
{{BinaryStringData}} form at ~line 499 and the String form at ~line 523) is
reachable from any query.
Remove {{StringCallGen.generateKeyValue}} and both
{{SqlFunctionUtils.keyValue}} overloads. {{BinaryStringDataUtil.keyValue}} is
otherwise referenced only by {{{}BinaryStringDataTest{}}}; decide whether to
keep it with its unit test or remove both together.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
