Hi all,

flink benchmarks has shown a rocksdb regression in mapstate since about Sep 27. 
The release 2-4 team needs a PMC decision on whether this regression is 
acceptable for 2.4.

The regressions are (ops/ms, baseline -> current):
- mapEntries.ROCKSDB: 294.5 -> 280.9 (-4.6%)
- mapIsEmpty.ROCKSDB: 38.0 -> 36.3 (-4.6%)
- mapIsEmpty.ROCKSDB_CHANGELOG: 38.3 -> 36.0 (-5.9%)
- mapIterator.ROCKSDB_CHANGELOG: 295.0 -> 283.2 (-4.0%)

The cause seems to be FLINK-40584 [0], which bounds MapState and timer prefix 
iterators with an iterate_upper_bound.
Each isEmpty, clear and MapState iterator load now creates and frees its own 
ReadOptions copy and native Slice.
It looks like this adds a fixed cost per call, which I was able to replicate by 
reverting and unreverting the commits and running
the benchmarks (mapIsEmpty sees the regression, mapGet unchanged).

In light of this, I've created a regression ticket to track a fix [1]

For release 2.4, should we accept this and ship as-is (maybe with a documented 
delta in the release notes) or revert the two commits from 2.4 if a fix is not 
present by our target date of Nov 24?

Thanks a ton,
Mika

[0] https://issues.apache.org/jira/browse/FLINK-40584
[1] https://issues.apache.org/jira/browse/FLINK-41519

Reply via email to