退订

邢颖
[email protected]



        



         原始邮件
         
       
发件人:Harshit Gupta (Jira) via dev <[email protected]&gt;
发件时间:2026年11月20日 17:38
收件人:dev <[email protected]&gt;
抄送:Harshit Gupta (Jira) <[email protected]&gt;
主题:[jira] [Created] (FLINK-41588) Pre-Commit Prefix Check



       Harshit&nbsp;Gupta&nbsp;created&nbsp;FLINK-41588:
-------------------------------------

&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Summary:&nbsp;Pre-Commit&nbsp;Prefix&nbsp;Check
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Key:&nbsp;FLINK-41588
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;URL:&nbsp;https://issues.apache.org/jira/browse/FLINK-41588
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Project:&nbsp;Flink
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Issue&nbsp;Type:&nbsp;Improvement
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Reporter:&nbsp;Harshit&nbsp;Gupta


In&nbsp;PR&nbsp;[https://github.com/apache/flink/pull/28643]&nbsp;we&nbsp;realised&nbsp;that&nbsp;Flink&nbsp;does&nbsp;not&nbsp;have&nbsp;any&nbsp;pre-commit&nbsp;check&nbsp;to&nbsp;make&nbsp;sure&nbsp;commit&nbsp;messages&nbsp;align&nbsp;with&nbsp;Flink's&nbsp;coding&nbsp;style&nbsp;guidelines&nbsp;as&nbsp;mentioned&nbsp;in&nbsp;[https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/.|https://flink.apache.org/how-to-contribute/code-style-and-quality-pull-requests/]&nbsp;The&nbsp;use&nbsp;case&nbsp;is&nbsp;to&nbsp;enforce&nbsp;coding&nbsp;these&nbsp;coding&nbsp;style&nbsp;guidelines.

&nbsp;

The&nbsp;idea&nbsp;is&nbsp;to&nbsp;either&nbsp;use&nbsp;[https://github.com/apache/calcite/blob/main/core/src/test/java/org/apache/calcite/test/LintTest.java]&nbsp;from&nbsp;Calcite&nbsp;(Probably&nbsp;extracting&nbsp;this&nbsp;into&nbsp;a&nbsp;separate&nbsp;library&nbsp;which&nbsp;can&nbsp;be&nbsp;used&nbsp;by&nbsp;both&nbsp;these&nbsp;projects,&nbsp;maybe&nbsp;other&nbsp;projects&nbsp;in&nbsp;the&nbsp;Flink&nbsp;environment)&nbsp;or&nbsp;use&nbsp;other&nbsp;tools&nbsp;which&nbsp;fit&nbsp;best&nbsp;for&nbsp;this&nbsp;usecase.

&nbsp;

Open&nbsp;questions&nbsp;right&nbsp;now
&nbsp;*&nbsp;Which&nbsp;tool&nbsp;to&nbsp;use&nbsp;for&nbsp;the&nbsp;pre-commit&nbsp;check?&nbsp;Does&nbsp;the&nbsp;Calcite&nbsp;self&nbsp;built&nbsp;tool&nbsp;also&nbsp;fulfils&nbsp;this&nbsp;usecase?
&nbsp;*&nbsp;Which&nbsp;all&nbsp;rules&nbsp;do&nbsp;we&nbsp;want&nbsp;to&nbsp;enforce&nbsp;in&nbsp;this&nbsp;pre-commit&nbsp;check?



--
This&nbsp;message&nbsp;was&nbsp;sent&nbsp;by&nbsp;Atlassian&nbsp;Jira
(v10.3.26#10030026)

Reply via email to