Hi Mike, I've looked on the generated artifacts and I do have few comments:
1) LICENSE file in binary artifact seems to be the same as in the source artifact. I believe that we need to update it in case of binary artifact and put there corresponding licenses for each library that we're shipping (for example all jars in lib/ directory that are not part of flume). 2) I'm failing on test TestHDFSEventSinkOnMiniCluster for binary artifact on my dev Ubuntu box. I'm not sure why as source artifact is fine and also I did not get any error on my mac. It's probably just some glitch in my environment: org.apache.flume.sink.hdfs.TestHDFSEventSinkOnMiniCluster Time elapsed: 3.534 sec <<< ERROR! java.lang.NullPointerException at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:422) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:280) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:124) at org.apache.flume.sink.hdfs.TestHDFSEventSinkOnMiniCluster.setup(TestHDFSEventSinkOnMiniCluster.java:73) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) at org.junit.runners.ParentRunner.run(ParentRunner.java:300) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) 3) Both binary and source artifacts contain same directory called apache-flume-1.2.0. I would advise different directories for each artifact (tarball) - for example apache-flume-1.2.0-dist for binary and apache-flume-1.2.0-src for source artifact. I believe that 2), and 3) are just fine, however 1) seems as a show stopper to me. Here are steps that I've done for each binary and source artifact: * Compile (only source artifact) * Run tests * Check LICENSE, NOTICE and other similar files * Run few example configurations * Check checksums (sha1, md5) Jarcec On Mon, Jul 09, 2012 at 10:15:21PM -0700, Mike Percy wrote: > This is the first release for Apache Flume as a top-level project, > version 1.2.0. We are voting on release candidate rc0. > > *** Please cast your vote within the next 72 hours *** > > The list of fixed issues: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc0/CHANGELOG > > The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) > for the source and binary artifacts can be found at: > https://people.apache.org/~mpercy/flume/apache-flume-1.2.0-rc0/ > > The tag to be voted on: > https://svn.apache.org/repos/asf/flume/tags/flume-1.2.0-rc0 > > The KEYS file can be found here: > https://svn.apache.org/repos/asf/flume/dist/KEYS
signature.asc
Description: Digital signature
