[ 
https://issues.apache.org/jira/browse/FLUME-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415621#comment-13415621
 ] 

Mubarak Seyed commented on FLUME-1373:
--------------------------------------

Hi Jarec,
I don't have an use-case to run on windows. I believe hadoop can be installed 
on windows. When i ran PMD/Findbugs to analyze the code, i had seen the 
hardcoded file separator violation. Thought of fixing it. Thanks.

>From hadoop-common [quick 
>start|http://hadoop.apache.org/common/docs/r0.20.2/quickstart.html]
{quote}
Win32 is supported as a development platform. Distributed operation has not 
been well tested on Win32, so it is not supported as a production platform
{quote}
                
> Remove hardcoded file separator in HDFSEventSink
> ------------------------------------------------
>
>                 Key: FLUME-1373
>                 URL: https://issues.apache.org/jira/browse/FLUME-1373
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>            Reporter: Mubarak Seyed
>            Priority: Trivial
>         Attachments: FLUME-1373.trunk.v1.patch
>
>
> configure() in HDFSEventSink hardcodes the file separator
> {code}
>     // FIXME: Not portable to Windows
>     this.path = dirpath + "/" + fileName;
> {code}
> Fix is very simple, just to use 
> {code}
>     this.path = dirpath + System.getProperty("file.separator") + fileName;
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to