----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6042/#review9278 -----------------------------------------------------------
Ship it! Looks good to me. Jarcec - Jarek Cecho On July 19, 2012, 6:22 a.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6042/ > ----------------------------------------------------------- > > (Updated July 19, 2012, 6:22 a.m.) > > > Review request for Flume. > > > Description > ------- > > Added file channel name to some log messages & exceptions. Also added timeout > length in HDFS Sink. These changes help with debugging in certain cases. > > > This addresses bug FLUME-1383. > https://issues.apache.org/jira/browse/FLUME-1383 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java > 77417ea > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java > d65d3da > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/LogFile.java > 0a94e04 > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/TransactionEventRecord.java > 21f42be > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecord.java > e81897e > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 024a4a8 > > Diff: https://reviews.apache.org/r/6042/diff/ > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Mike Percy > >
