> On July 27, 2012, 3:09 p.m., Jarek Cecho wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java, > > lines 151-165 > > <https://reviews.apache.org/r/6170/diff/2/?file=130109#file130109line151> > > > > Just a question here - do we really need to create new callback > > objects here each time? Wouldn't be possible to reuse them and spare the > > time on creating objects?
Yes, you are right. Updating patch. > On July 27, 2012, 3:09 p.m., Jarek Cecho wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java, > > lines 134-135 > > <https://reviews.apache.org/r/6170/diff/2/?file=130109#file130109line134> > > > > I believe that assigning zero to variable "i" might be done here only > > once. fixing. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6170/#review9534 ----------------------------------------------------------- On July 27, 2012, 7:29 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6170/ > ----------------------------------------------------------- > > (Updated July 27, 2012, 7:29 a.m.) > > > Review request for Flume. > > > Description > ------- > > Made some concurrency modifications to Async hbase sink. Also, now backs off > only if no events were fetched from channel - like Avro sink. > > > This addresses bug FLUME-1398. > https://issues.apache.org/jira/browse/FLUME-1398 > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java > 078c5a3 > > Diff: https://reviews.apache.org/r/6170/diff/ > > > Testing > ------- > > Exising unit tests pass. Functional testing done. > > > Thanks, > > Hari Shreedharan > >
