-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6183/
-----------------------------------------------------------

(Updated July 30, 2012, 6:51 a.m.)


Review request for Flume.


Changes
-------

Updating based on Brock's feedback. Moved error processing to another method. 
Added txn.close() now called after txn.commit(), since txn.close() is called on 
failure from handleTxnFailure method.


Description
-------

Timeout the sink if all callbacks are not received within the configurable 
timeout.


This addresses bug FLUME-1401.
    https://issues.apache.org/jira/browse/FLUME-1401


Diffs (updated)
-----

  flume-ng-doc/sphinx/FlumeUserGuide.rst 56011e8 
  
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/AsyncHBaseSink.java
 6df1f33 
  
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkConfigurationConstants.java
 a16cda8 

Diff: https://reviews.apache.org/r/6183/diff/


Testing
-------

All unit tests pass. Did functional testing.


Thanks,

Hari Shreedharan

Reply via email to