> On July 31, 2012, 2:57 a.m., Hari Shreedharan wrote: > > Generally looks good. I have one small suggestion though.
Also, there is at least one other place where we should throw the throwable as is: NettyAvroRpcClient#append method has an future.get call. I think we should catch throw the cause of the ExecutionException if it is instance of RuntimeException or Error. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6220/#review9620 ----------------------------------------------------------- On July 31, 2012, 1:55 a.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6220/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 1:55 a.m.) > > > Review request for Flume. > > > Description > ------- > > Logs uncaught throwables when they would not have been logged. > > > This addresses bug FLUME-1408. > https://issues.apache.org/jira/browse/FLUME-1408 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/instrumentation/GangliaServer.java > 1104141 > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java > 2ac94df > > flume-ng-node/src/main/java/org/apache/flume/conf/file/AbstractFileConfigurationProvider.java > 9f900d3 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 75ff069 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > d65c5a8 > > Diff: https://reviews.apache.org/r/6220/diff/ > > > Testing > ------- > > > Thanks, > > Brock Noland > >
