> On Aug. 18, 2012, 4:21 a.m., Hari Shreedharan wrote: > > flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java, > > line 104 > > <https://reviews.apache.org/r/6684/diff/1/?file=142689#file142689line104> > > > > I'm afraid this will cause the same problem we were facing with the > > integration tests earlier, since it was possible that the test would fail > > because the agent didn't start up in 3 seconds. I don't mind this getting > > committed as is, but please file a followup jira. > > Hari Shreedharan wrote: > I just tried running the other tests(this would not run) on a Macbook > air, and had to put in a much higher timeout than already in the code for the > test to not fail. So 3 seconds seems low to be a general case.
Verified that this test runs, so you can just increase the sleep timeout to something higher or more deteministic. > On Aug. 18, 2012, 4:21 a.m., Hari Shreedharan wrote: > > flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java, > > line 99 > > <https://reviews.apache.org/r/6684/diff/1/?file=142689#file142689line99> > > > > There is a potential issue here. Dependencies of hadoop do not get > > added to the classpath. If the hadoop classes we use depend on anything > > which flume has not already pulled in, this would cause issues. I don't > > immediately have access to a machine with no hadoop, but if you do please > > see if this will run fine on that. Please confirm that this works on a > > machine without hadoop installed(hadoop binary is not available). I confirmed that this test works on a machine installation. You can ignore the above comment. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6684/#review10489 ----------------------------------------------------------- On Aug. 18, 2012, 12:30 a.m., Will McQueen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6684/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2012, 12:30 a.m.) > > > Review request for Flume. > > > Description > ------- > > First integration test for file channel > > > This addresses bug FLUME-1492. > https://issues.apache.org/jira/browse/FLUME-1492 > > > Diffs > ----- > > flume-ng-tests/pom.xml 7d5ebed > > flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java > e69de29 > flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java > 3e7940d > > Diff: https://reviews.apache.org/r/6684/diff/ > > > Testing > ------- > > > Thanks, > > Will McQueen > >
