----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6756/#review10741 -----------------------------------------------------------
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java <https://reviews.apache.org/r/6756/#comment23178> We can get this same information from the inflights. It will have a very slight cost of generating the list but that should be trivial (less than a millisecond) compared with the disk operations we do turning a checkpoint taking many milliseconds. With the advantage that is makes this more understandable. - Brock Noland On Aug. 24, 2012, 4:33 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6756/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 4:33 a.m.) > > > Review request for Flume, Arvind Prabhakar and Brock Noland. > > > Description > ------- > > Keep track of file ids of non-committed transactions also. Remove them only > when the transaction gets committed. > > > This addresses bug FLUME-1428. > https://issues.apache.org/jira/browse/FLUME-1428 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FlumeEventQueue.java > 766c59a > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java > 2093839 > > Diff: https://reviews.apache.org/r/6756/diff/ > > > Testing > ------- > > Added a unit test for this case. > > > Thanks, > > Hari Shreedharan > >
