----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6965/#review11200 -----------------------------------------------------------
Ship it! Ship It! - Hari Shreedharan On Sept. 8, 2012, 4:11 a.m., Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6965/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2012, 4:11 a.m.) > > > Review request for Flume. > > > Description > ------- > > This patch does 3 minor things: > 1. trim() newlines from the passwords contained in password files > 2. Print a more useful warning to the error logs if the user tries to use > strong encryption but has not installed the required policy files > 3. Trivial indentation change > > > This addresses bug FLUME-1546. > https://issues.apache.org/jira/browse/FLUME-1546 > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/AESCTRNoPaddingProvider.java > b77e10c > > flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/JCEFileKeyProvider.java > fff78e0 > > Diff: https://reviews.apache.org/r/6965/diff/ > > > Testing > ------- > > Manual testing, unit tests pass. > > > Thanks, > > Mike Percy > >
