-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7082/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Put's null checks in places and in the FileChannel class, stores the startup 
exception so we can given users more information when createTransaction() is 
called. I have noticed several times where "file channel is closed" is shared 
as the error. If we can include more information in that message, I think it 
will make for a better user experience.


This addresses bug FLUME-1575.
    https://issues.apache.org/jira/browse/FLUME-1575


Diffs
-----

  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
 66f7536 
  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/CipherProvider.java
 3b8d6c3 
  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/JCEFileKeyProvider.java
 4c53df4 
  
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/encryption/KeyProvider.java
 e0877d1 

Diff: https://reviews.apache.org/r/7082/diff/


Testing
-------

units pass


Thanks,

Brock Noland

Reply via email to