-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7269/
-----------------------------------------------------------

Review request for Flume.


Description
-------

Ensure that flush() is always called before close(). Also fix race condition 
between checks for whether we should flush and then actually flushing (wrap the 
check & action in a synchronized block).


This addresses bug FLUME-1610.
    https://issues.apache.org/jira/browse/FLUME-1610


Diffs
-----

  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
 6408eb9 
  
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
 9a76ecb 
  
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
 bb12188 

Diff: https://reviews.apache.org/r/7269/diff/


Testing
-------

Brock's unit test passes. Also some manual testing.


Thanks,

Mike Percy

Reply via email to