Hi, OK, sounds good. I will resolve those today and send out another RC.
On Mon, Nov 12, 2012 at 10:18 AM, Jarek Jarcec Cecho <[email protected]> wrote: > -1 (please see my notes below for show stopper). > > Hi Brock, > thank you very much for your great work on this release candidate. I'm sorry > for my -1, however I've noticed licensing issues that I believe needs to be > resolved first. > > Show stoppers: > * LICENSE file in binary artifact seems to be missing license notes for > following third party jars: gson-2.2.2.jar, protobuf-java-2.4.1.jar, > mina-core-2.0.4.jar > > Notes: > * Both artifacts seems to have directory apache-flume-1.3.0. It would be nice > if artifact apache-flume-1.3.0.tar.gz would have directory apache-flume-1.3.0 > (e.g. current state) and apache-flume-1.3.0-bin.tar.gz would have directory > apache-flume-1.3.0-bin. It's very nice practise to distribute tarballs that > have directory with exactly the same name as the tarball itself minus suffix. > I know that flume 1.2.0 was released with this already, so this is merely a > suggestion :-) > * It seems that we're still depending on "export MAVEN_OPTS="-Xms512m > -Xmx1024m -XX:PermSize=256m -XX:MaxPermSize=512m"". It would be nice do > document it somewhere, but again, no difference from flume 1.2.0, so just a > suggestion. > > Validations: > * Verified checksums > * Tests seems to be passing > > Jarcec > > On Sun, Nov 11, 2012 at 06:27:49PM -0600, Brock Noland wrote: >> This is the second release for Apache Flume as a top-level project, >> version 1.3.0. We are voting on release candidate rc0. >> >> *** Please cast your vote within the next 72 hours *** >> >> The list of fixed issues: >> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=blob_plain;f=CHANGELOG;hb=8b748e3851f9378bc319af0c8b08c9ff0a044c1b >> >> The tarball (*.tar.gz), signature (*.asc), and checksums (*.md5, *.sha1) >> for the source and binary artifacts can be found at: >> http://people.apache.org/~brock/flume-1.3.0-rc0/ >> >> The tag to be voted on: >> https://git-wip-us.apache.org/repos/asf?p=flume.git;a=commit;h=8b748e3851f9378bc319af0c8b08c9ff0a044c1b >> >> The KEYS file can be found here: >> https://dist.apache.org/repos/dist/release/flume/KEYS -- Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
