----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8328/#review14008 -----------------------------------------------------------
Does not look like you are creating LoadBalancingRpcClient anywhere. Also I don't think there is a need for more getInstance methods, just use the one currently available - pass in a properties instance. - Hari Shreedharan On Dec. 3, 2012, 8:52 p.m., Cameron Gandevia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8328/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2012, 8:52 p.m.) > > > Review request for Flume. > > > Description > ------- > > The Log4jAppender should be extended to use the LoadBalancingRpcClient > allowing users to configure a load balancing log4jappender > > > Diffs > ----- > > > flume-ng-clients/flume-ng-log4jappender/src/main/java/org/apache/flume/clients/log4jappender/Log4jAppender.java > 083f5d1 > flume-ng-doc/sphinx/FlumeUserGuide.rst f8528bb > flume-ng-sdk/src/main/java/org/apache/flume/api/HostInfo.java 7388a45 > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java > 3c93921 > > Diff: https://reviews.apache.org/r/8328/diff/ > > > Testing > ------- > > > Thanks, > > Cameron Gandevia > >
