[
https://issues.apache.org/jira/browse/FLUME-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510900#comment-13510900
]
Mike Percy commented on FLUME-1321:
-----------------------------------
I'm saying we should stop throwing IllegalStateException from close(). It
should just log a warning and roll back the transaction, in my opinion. Right
now, if the finally block is reached by a thrown exception, while the
transaction is still open, the first exception is obliterated and replaced with
the IllegalStateException. That sucks because it's difficult/impossible to tell
what went wrong in the first place.
> BasicTransactionSemantics should never throw from close()
> ---------------------------------------------------------
>
> Key: FLUME-1321
> URL: https://issues.apache.org/jira/browse/FLUME-1321
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0
> Reporter: Mike Percy
> Assignee: Roshan Naik
> Fix For: v1.4.0
>
>
> Currently, BasicTransactionSemantics can throw from close(). This means that
> exceptions will be clobbered in cases where unexpected exceptions are thrown,
> since close() is idiomatically called in a finally block.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
