----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8421/#review14743 -----------------------------------------------------------
Brock, Generally looks good. I have a couple of questions though: * The components list in ChannelComponent class seems to be not used. The only time it is actually used is to check if it is empty (otherwise the components are simply added to it). I think this list can easily be replaced by a boolean right? * Assume that the components is required for something (which I missed), then we need 2 lists for sources and sinks, since we can have a source and a sink with the same name. - Hari Shreedharan On Dec. 19, 2012, 4:26 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8421/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 4:26 p.m.) > > > Review request for Flume. > > > Description > ------- > > Catches Exception around all the configure() methods of components. If they > throw an exception, they are removed from the configuration (not added). > > > This addresses bug FLUME-1772. > https://issues.apache.org/jira/browse/FLUME-1772 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/node/AbstractConfigurationProvider.java > daef76b > > flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java > 25001b1 > > Diff: https://reviews.apache.org/r/8421/diff/ > > > Testing > ------- > > Tests added for source, channel, and sink. > > > Thanks, > > Brock Noland > >
