----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9352/#review16398 -----------------------------------------------------------
Looks great! A few comments below. Also, does this have to be added to the dist pom? I know I have had trouble with things like the JMS source because I didn't add it to the n requisite places. flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java <https://reviews.apache.org/r/9352/#comment34882> I don't see a formatting place for this string. Not sur what log4j will do with the second string passed as an arg. flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java <https://reviews.apache.org/r/9352/#comment34884> Do we want to log the exception or exception message here? flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java <https://reviews.apache.org/r/9352/#comment34883> Does log4j accept string formatting? Typically I see {} being used. flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java <https://reviews.apache.org/r/9352/#comment34885> This is a more reliable mechanism to find a free port: ServerSocket socket = new ServerSocket(0); int port = socket.getLocalPort(); socket.close(); - Brock Noland On Feb. 8, 2013, 9:36 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9352/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 9:36 a.m.) > > > Review request for Flume. > > > Description > ------- > > Thrift Source. > > > This addresses bug FLUME-1898. > https://issues.apache.org/jira/browse/FLUME-1898 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java > 3312b04 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java > 058ca1c > flume-ng-core/pom.xml 7db4f23 > flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java > PRE-CREATION > flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/9352/diff/ > > > Testing > ------- > > Added several unit tests. > > > Thanks, > > Hari Shreedharan > >
