----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9568/#review17211 -----------------------------------------------------------
Ship it! +1 - Mike Percy On Feb. 27, 2013, 3:55 a.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9568/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 3:55 a.m.) > > > Review request for Flume. > > > Description > ------- > > Only wrap the real HDFS calls in timeout callables. > > > This addresses bug FLUME-1925. > https://issues.apache.org/jira/browse/FLUME-1925 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 0786857 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 76e3d1f > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > ebe277c > > Diff: https://reviews.apache.org/r/9568/diff/ > > > Testing > ------- > > All current tests pass. > > > Thanks, > > Hari Shreedharan > >
