[ 
https://issues.apache.org/jira/browse/FLUME-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634675#comment-13634675
 ] 

Mike Percy commented on FLUME-1993:
-----------------------------------

Hi [~paulchavez], I think you got to the bottom of this one. Yep, it's a bug 
and I agree with your change to ReliableSpoolingFileEventReader.java. However, 
I am unclear on why you made the change you did to DurablePositionTracker.java. 
As far as I can tell, we already check at the top of getInstance() whether the 
file exists, so an additional check should be unnecessary.

By the way, I had trouble applying your patch as well. I think you have a UTF 
BOM at the beginning of the file or something because it's messing with all my 
tools. I was able to manually remove those bytes and eventually apply your 
patch, but I bet that's why Review Board didn't like it.
                
> On Windows, when using the spooling directory source, there is a file sharing 
> violation when trying to delete tracker file
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLUME-1993
>                 URL: https://issues.apache.org/jira/browse/FLUME-1993
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.4.0
>            Reporter: Phil Scala
>         Attachments: FLUME-1993.patch, ReliableSpoolingFileEventReader.java, 
> ReliableSpoolingFileEventReader.java.patch
>
>
> spooling directory source
> org.apache.flume.client.avro.ReliableSpoolingFileEventReader.getNextFile() 
> Gets an instance of a DurablePositionTracker and is not calling close() on it 
> before then creating another instance... thus not calling close on the 
> underlying DataFileWriter.  This left the file locked in Windows and hence 
> any delete attempts were failing...causing the Agent to spin around and 
> around trying to delete this file and creating endless numbers of the 
> temporary tracker files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to