[ 
https://issues.apache.org/jira/browse/FLUME-2032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682937#comment-13682937
 ] 

Mike Percy commented on FLUME-2032:
-----------------------------------

+1, looks good
                
> HDFSEventSink doesn't work in Windows
> -------------------------------------
>
>                 Key: FLUME-2032
>                 URL: https://issues.apache.org/jira/browse/FLUME-2032
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources, Windows
>    Affects Versions: v1.3.0
>         Environment: Windows.
>            Reporter: Pedro Urbina Escos
>            Priority: Trivial
>             Fix For: v1.4.0
>
>         Attachments: FLUME-2032.patch, FLUME-2032.rebased.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Fix for [FLUME-1373] (Remove hardcoded file separator in HDFSEventSink ) 
> regressed the HDFS in Windows. The fix was done per PMD/Findbugs alert. The 
> fix was to replace '/' with the OS file separator. The problem is that the 
> code is not trying to build a local path; it's trying to combine strings to 
> form a URI. In Linux, OS separator is '/' and this is not a problem. In 
> windows, OS separator is '\' and therefore you end up with paths like 
> hdfs://foo\var. The best fix would be to use URL objects but new 
> URL("hdfs://..") throws unknown protocol HDFS. The most cost effective fix 
> seems to be revert to hardcoding '/'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to