----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14176/#review26287 -----------------------------------------------------------
Thanks for the patch. This looks good. I have one request though - please add a test where filtering and SSL are enabled on the same source to ensure that combination works. - Hari Shreedharan On Sept. 19, 2013, 7:13 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14176/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2013, 7:13 p.m.) > > > Review request for Flume. > > > Bugs: Flume-2189 > https://issues.apache.org/jira/browse/Flume-2189 > > > Repository: flume-git > > > Description > ------- > > This patch does the following > adds support for ipFiltering on the avroSource > adds unit testing for configuring ipFiltering on the avroSource > adds documentation in the user's guide > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java f23cd93 > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > 2667a6f > flume-ng-doc/sphinx/FlumeUserGuide.rst c614991 > pom.xml 25ea4e7 > > Diff: https://reviews.apache.org/r/14176/diff/ > > > Testing > ------- > > > Thanks, > > Ted Malaska > >
