----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14444/#review26794 -----------------------------------------------------------
Ship it! +1, running unit tests and committing - Mike Percy On Oct. 2, 2013, 5:04 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14444/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 5:04 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2200 > https://issues.apache.org/jira/browse/FLUME-2200 > > > Repository: flume-git > > > Description > ------- > > Both normal and SSL should use "port" instead of having separate parameters > for each. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSource.java > 84ee33b > > flume-ng-core/src/main/java/org/apache/flume/source/http/HTTPSourceConfigurationConstants.java > 205aeab > > flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java > 9e14648 > flume-ng-doc/sphinx/FlumeUserGuide.rst 5a59b56 > > Diff: https://reviews.apache.org/r/14444/diff/ > > > Testing > ------- > > All unit tests pass with updated parameter. > > > Thanks, > > Hari Shreedharan > >
