[ 
https://issues.apache.org/jira/browse/FLUME-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840246#comment-13840246
 ] 

Brock Noland commented on FLUME-2181:
-------------------------------------

Hari,

Two review items: syncExecutor can be null during close and even if we don't 
sync, I do think we should flush, no? Otherwise a kill of the process can lose 
data without a kill of the machine.

Can you speak to the action the user will take when the channel is corrupt? 
From what I can tell, it's possible holes develop in the file during a crash, 
possibly contained in an event or across event boundaries. Should this feature 
coincide with the ability to skip bad events in the logs and skip the end of 
file during replay?

> Optionally disable File Channel fsyncs 
> ---------------------------------------
>
>                 Key: FLUME-2181
>                 URL: https://issues.apache.org/jira/browse/FLUME-2181
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>         Attachments: FLUME-2181.patch
>
>
> This will give File Channel performance a big boost, at the cost of possible 
> data loss if a crash happens between checkpoints. 
> Also we should make it configurable, with default to false. If the user does 
> not mind slight inconsistencies, this feature can be explicitly enabled 
> through configuration. So if it is not configured, then the behavior will be 
> exactly as it is now.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to