[ https://issues.apache.org/jira/browse/FLUME-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881731#comment-13881731 ]
Hari Shreedharan commented on FLUME-2181: ----------------------------------------- If fsyncPerTransaction is true, then it is current behavior. I am not throwing any exception if a read ends up hitting a corrupt header or event when the fsyncPerTransaction is not true (that is every transactional commit does not cause an fsync, only periodic fsync happens). The first one you mentioned is what I intended, don't throw if fsyncPerTransaction is false (if you meant throwing an IOException is wrong, we can change that to a CorruptEventException). The last one is a bug, we should throw an exception only if fsyncPerTransaction is true. > Optionally disable File Channel fsyncs > --------------------------------------- > > Key: FLUME-2181 > URL: https://issues.apache.org/jira/browse/FLUME-2181 > Project: Flume > Issue Type: Improvement > Reporter: Hari Shreedharan > Assignee: Hari Shreedharan > Attachments: FLUME-2181-1.patch, FLUME-2181.patch > > > This will give File Channel performance a big boost, at the cost of possible > data loss if a crash happens between checkpoints. > Also we should make it configurable, with default to false. If the user does > not mind slight inconsistencies, this feature can be explicitly enabled > through configuration. So if it is not configured, then the behavior will be > exactly as it is now. -- This message was sent by Atlassian JIRA (v6.1.5#6160)