[
https://issues.apache.org/jira/browse/FLUME-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893456#comment-13893456
]
Brock Noland commented on FLUME-2311:
-------------------------------------
Nice! This patch generally looks great! The only issue I see is that the patch
uses tabs (or 4 spaces) as opposed to 2 spaces. Would you mind re formatting
the patch?
> Use standard way of finding queue/topic
> ---------------------------------------
>
> Key: FLUME-2311
> URL: https://issues.apache.org/jira/browse/FLUME-2311
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.4.0
> Reporter: Brock Noland
> Labels: flume, jms, patch
> Attachments: 0001-Patch-for-FLUME-2311.patch
>
>
> Here
> https://issues.apache.org/jira/browse/FLUME-924?focusedCommentId=13890651&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13890651
> [~hlassiege] says:
> I'm currently using this jms source to connect on Weblogic message bus. I'm
> wondering why the JMSMessageConsumer use createQueue and createTopic instead
> of lookup to find the destinations (line 83 to 90).
> It seems that "createQueue" or "createTopic" are not the recommended way
> because it is not portable (I saw that warning in Weblogic documentation even
> if I can't justify this assertion).
> The documentation recommends to use a JNDI lookup
> (http://docs.oracle.com/cd/E23943_01/web.1111/e13727/lookup.htm#BABDFCIC).
> Is there any reason to use createQueue instead of lookup ?
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
