[ 
https://issues.apache.org/jira/browse/FLUME-2251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130421#comment-14130421
 ] 

Hari Shreedharan commented on FLUME-2251:
-----------------------------------------

Also, to just fit in with the convention - do you think calling the 
MessagePreprocessor MessageSerializer makes more sense? Instead of having 3 
methods in that class why not simply have 1? Also like the HBaseSink I'd rather 
have it return a list of KeyedMessages than just 1 (you could break a single 
Event into multiple KeyedMessages). So the Serializer interface would look 
something like:

{code}
public interface KafkaSerializer extends Configurable {
    List<KeyedMessage> getKeyedMessages(Event e);
}
{code}

> Add support for Kafka Sink
> --------------------------
>
>                 Key: FLUME-2251
>                 URL: https://issues.apache.org/jira/browse/FLUME-2251
>             Project: Flume
>          Issue Type: Sub-task
>          Components: Sinks+Sources
>    Affects Versions: v1.4.0
>            Reporter: Ashish Paliwal
>            Priority: Minor
>              Labels: feature, patch
>         Attachments: FLUME-2251-0.patch, FLUME-2251-2.patch, 
> FLUME-2251-3.patch, FLUME-2251.patch, FLUME-2251.patch, Flume-2251-1.patch
>
>
> Add support for Kafka Sink



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to