----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26820/#review58632 -----------------------------------------------------------
Looks good! Do you want to do the docs in this patch or a separate one? - Gwen Shapira On Oct. 23, 2014, 6:58 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26820/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 6:58 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2500 > https://issues.apache.org/jira/browse/FLUME-2500 > > > Repository: flume-git > > > Description > ------- > > Add a channel that uses Kafka > > > Diffs > ----- > > flume-ng-channels/flume-kafka-channel/pom.xml PRE-CREATION > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > PRE-CREATION > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannelConfiguration.java > PRE-CREATION > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java > PRE-CREATION > > flume-ng-channels/flume-kafka-channel/src/test/resources/kafka-server.properties > PRE-CREATION > flume-ng-channels/flume-kafka-channel/src/test/resources/log4j.properties > PRE-CREATION > > flume-ng-channels/flume-kafka-channel/src/test/resources/zookeeper.properties > PRE-CREATION > flume-ng-channels/pom.xml dc8dbc6 > flume-ng-sinks/flume-ng-kafka-sink/pom.xml 746a395 > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/KafkaConsumer.java > 1c98922 > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/TestUtil.java > 8855c53 > pom.xml 4f550d3 > > Diff: https://reviews.apache.org/r/26820/diff/ > > > Testing > ------- > > Added tests that simulate a Kafka cluster. > > > Thanks, > > Hari Shreedharan > >
