----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33215/#review80205 -----------------------------------------------------------
flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java <https://reviews.apache.org/r/33215/#comment129990> This should not only check if it's null, but also if it's a json content type. flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java <https://reviews.apache.org/r/33215/#comment129991> You don't have to create a tmp builder. To make sure the JSON is valid, you just have to do: while(parser.nextToken() != null) { } - Francis Page On April 15, 2015, 9:56 a.m., Benjamin Fiorini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33215/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 9:56 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Elasticsearch sink fails to index malformed nested JSON > > > Diffs > ----- > > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > de0acf4 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java > 2f8fd6d > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java > 78e1665 > > Diff: https://reviews.apache.org/r/33215/diff/ > > > Testing > ------- > > > Thanks, > > Benjamin Fiorini > >
