----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36105/#review90374 -----------------------------------------------------------
Ship it! +1, Looks good, very minor Nits flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java (line 25) <https://reviews.apache.org/r/36105/#comment143412> Nit: Can we avoid .* flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java (line 33) <https://reviews.apache.org/r/36105/#comment143413> Nit: Not needed to specify again - implements PollableSource and Configurable flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java (line 26) <https://reviews.apache.org/r/36105/#comment143414> Nit: .* to be changed back flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java (line 51) <https://reviews.apache.org/r/36105/#comment143415> Nit: Not needed to specify again - implements PollableSource and Configurable flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java (line 72) <https://reviews.apache.org/r/36105/#comment143417> Not needed to specify implements Configurable and implements PollableSource - Johny Rufus John On July 2, 2015, 4:03 p.m., Ted Malaska wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36105/ > ----------------------------------------------------------- > > (Updated July 2, 2015, 4:03 p.m.) > > > Review request for Flume and Johny Rufus John. > > > Repository: flume-git > > > Description > ------- > > There are use cases that require more control of the backoff times setting. > This jira will allow those times to be set through config of the source > > > Diffs > ----- > > > flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java > 4e2f940 > flume-ng-core/src/main/java/org/apache/flume/PollableSource.java e872b0c > > flume-ng-core/src/main/java/org/apache/flume/source/AbstractPollableSource.java > 356f4d4 > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceConstants.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/source/PollableSourceRunner.java > f6c64b3 > > flume-ng-core/src/main/java/org/apache/flume/source/SequenceGeneratorSource.java > 51e021a > flume-ng-core/src/main/java/org/apache/flume/source/StressSource.java > 0e7020b > > flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java > 02a2f0c > > flume-ng-core/src/test/java/org/apache/flume/source/TestPollableSourceRunner.java > 4d4222d > > flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java > c9d3e20 > flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java > 28270f4 > > flume-ng-sources/flume-kafka-source/src/main/java/org/apache/flume/source/kafka/KafkaSource.java > 3777639 > > Diff: https://reviews.apache.org/r/36105/diff/ > > > Testing > ------- > > All existing test pass. I would like to add a new test that will confirm > that values are read correctly from the config. > > > Thanks, > > Ted Malaska > >
