[ https://issues.apache.org/jira/browse/FLUME-2889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15170042#comment-15170042 ]
Hari Shreedharan commented on FLUME-2889: ----------------------------------------- Sounds good, [~roshan_naik] - lets revert the last one and commit this one. This one LGTM, so +1. I'd still wait for [~tmgstev] to take a look, since he caught the issue earlier. > Fixes to DateTime computations > ------------------------------- > > Key: FLUME-2889 > URL: https://issues.apache.org/jira/browse/FLUME-2889 > Project: Flume > Issue Type: Bug > Affects Versions: v1.6.0 > Reporter: Roshan Naik > Assignee: Roshan Naik > Fix For: v1.7.0 > > Attachments: FLUME-2889-2.patch, FLUME-2889.3.patch, FLUME-2889.patch > > > date.withYear(year+1) can lead to incorrect date calculations .. for example > if the date is Feb 29th. need to use date.plusYears(1) instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)